Linux build fixes (absorb upstream PR #15) - #2
Merged
Conversation
Corrects the AppImage/Docker Linux build: the profile-validator CMake target is named OrcaSlicer_profile_validator (not Orca-Flashforge_profile_validator), the Docker entrypoint binary is orca-flashforge, and adds Linux build instructions to the README. Absorbs FlashForge#15 by ArseniSoitu; the PR's MPFR.cmake hunk is omitted as that fix is already present on this branch. Co-authored-by: ArseniSoitu <ArseniSoitu@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absorbs the stalled upstream PR FlashForge#15 (by @ArseniSoitu) into our fork.
BuildLinux.sh— build the correctly-namedOrcaSlicer_profile_validatortarget.Dockerfile— entrypoint binary isorca-flashforge.README.md— add Linux (Docker/AppImage) build instructions.The PR's
deps/MPFR/MPFR.cmakehunk (switchmpfr-current/→ versionedmpfr-4.2.1/URL) is omitted because that fix is already present onmain.Note: verified by inspection against this repo's CMake (the profile-validator target really is
OrcaSlicer_profile_validator); not runtime-tested on Linux from here.🤖 Generated with Claude Code