[1st · merge first] Stop linking seller names to a JoomPulse page that does not exist - #41
Merged
Conversation
pulse://overview rule 10 restricts the beginner-products/{id} template to
listing ids and skips seller grain. This skill asks for the Vendedor name to
link to "the seller's JoomPulse page". In a live run every one of those links
was built from a shopId and 404ed — nine dead URLs in a single answer.
Two places were promising it:
- the presentation rule in the body, which now states the name is plain text
and why;
- the frontmatter description, which advertised "...listing-type counts, with
a JoomPulse link each". That one matters more than it looks: descriptions
are injected into the system prompt for skill selection, so the promise
shipped even in conversations where this skill never loaded.
Nothing else changes — no column, threshold or ranking rule is touched.
fiharet34
force-pushed
the
fix/no-seller-joompulse-link
branch
from
September 11, 2026 11:05
e48a332 to
0cf23ab
Compare
fiharet34
pushed a commit
to fiharet34/joompulse-skills
that referenced
this pull request
Sep 14, 2026
Both branches rewrote the same two passages. Resolved by keeping this branch's fuller field list and its added guidance, and taking joomcode#41's correction throughout: sellers have no JoomPulse page, so the Vendedor name is plain text and the description no longer promises a link per seller. Merging it here rather than leaving the clash for whoever lands these second. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
fiharet34
marked this pull request as ready for review
September 14, 2026 12:58
fiharet34
changed the title
fiharet34
changed the title
profunctor
approved these changes
Sep 28, 2026
profunctor
added a commit
that referenced
this pull request
Sep 28, 2026
…s, and stop reading buy-box position as idle stock (#35) * Fix top-sellers-in-category: rank against real sales, and stop reading buy-box position as idle stock Checks each estimate against the seller's real completed sales before placing a row: shops with no real trading history move out of the ranking into a labelled group, while a real business whose estimate runs high stays in with a caveat. Groups shops sharing a name stem and says whether that changes the leader, without asserting common ownership. Reframes the registered-versus-with-sales comparison as sellers only. On a catalog product only the buy-box holder shows sales, so the product gap measures buy-box position rather than idle inventory - and since the panel now renders every run, an unlabelled version of that chart would mislead every time. Also: medal as a column so the saved baseline can reproduce its own panel, the growth column named for the metric it carries, full money precision in a ranking, a missing-value rule, a width fallback that drops columns rather than the table, retry after a pause, and an empty result separated from an outage. * Stop linking seller names to a JoomPulse page that does not exist pulse://overview rule 10 restricts the beginner-products/{id} template to listing ids and skips seller grain. This skill asks for the Vendedor name to link to "the seller's JoomPulse page". In a live run every one of those links was built from a shopId and 404ed — nine dead URLs in a single answer. Two places were promising it: - the presentation rule in the body, which now states the name is plain text and why; - the frontmatter description, which advertised "...listing-type counts, with a JoomPulse link each". That one matters more than it looks: descriptions are injected into the system prompt for skill selection, so the promise shipped even in conversations where this skill never loaded. Nothing else changes — no column, threshold or ranking rule is touched. * Name the shapes that are not a leaderboard "Never abandon the table for a seller-by-seller list" left room for the shapes a live pass actually produced: the leaders in the table with the rest in prose, and a trailing "and below them, X, Y, Z" sentence. Both look like a leaderboard and neither can be compared row against row next period, which is the whole reason the seller keeps it. Names those shapes and ends with the check to apply before answering. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Nikita Andreev <nikita.andreev@joom-contractors.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Co-authored-by: Artem Plotnikov <aplotnikov@joom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vendedor name linked to a seller's JoomPulse page. Sellers have no such page: the dashboard link template is for listing ids only, so a URL built from a shopId 404s.
The name is now plain text, and the skill's description no longer promises a link per seller.
🤖 Generated with Claude Code