Repository navigation
upstream: Review Julia through 12fbf6b9b315 - #15
Merged
github-actions[bot] merged 3 commits intoSep 19, 2026
Merged
Conversation
JuliaLang#63251) Previously `jl_disable_binding` checked for an existing guard partition lock-free and then looped on `jl_replace_binding`, retrying whenever the partition head had moved in between. Inline the equivalent operation: take `world_counter_lock` once, resolve the partition at the new world (as the other locked callers do), and replace it in place with no retry. Besides removing the race between the check and the replacement, this gives the deletion a locked window between resolving the old partition and publishing the guard partition. A following change uses that window to flag the superseded partitions before deleting a declared global. Assisted-by: Claude Code (Opus 4.8, Opus 5, Fable 5) and OpenAI Codex Co-authored-by: Keno Fischer <Keno@users.noreply.github.com>
Assisted-by: Codex (GPT-5.6 Luna)
Assisted-by: Codex (GPT-5.6 Luna)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Julia
53efe7eca879b513b199718847e6f30e7c86ff70→12fbf6b9b315b71aaa96b7a766c5c23c89f36d90.Reviewed the merged upstream change and Joolia context. It only changes synchronization for binding invalidation in src/module.c; no zero-origin adaptation is required. No source or test files were changed, and no builds or tests were run.
Draft for human review. Automatic merging is disabled.
The upstream history is preserved in a merge commit; any Joolia adaptations are committed separately. The publisher explicitly dispatches Joolia CI on this branch; inspect its result before merging.
Review record:
contrib/upstream-sync/reports/12fbf6b9b315b71aaa96b7a766c5c23c89f36d90.json.Incoming commits:
12fbf6b9b315b71aaa96b7a766c5c23c89f36d90— module: performjl_disable_bindingunderworld_counter_lock[NFCI] (change 63251)Merge integrated batches with a merge commit, never squash/rebase, to preserve the upstream ancestry.
Passing CI covers only
contrib/ci/coverage.json; it does not certify the entire port.