Repository navigation
upstream: Review Julia through 53efe7eca879 - #14
Merged
github-actions[bot] merged 3 commits intoSep 19, 2026
Merged
Conversation
…aLang#63250) `jl_checked_modify` and `jl_checked_replace` reused the field helpers `modify_value` and `replace_value`, which for that purpose carried binding-only parameters (`modify_value` took the binding, its partition, module and name; `replace_value` took the module and name) that every other caller passed as NULL. Write the compare-and-swap loops out instead and drop those parameters, along with the now-unreachable `jl_undefined_var_error` branches, from the field helpers. The binding loops behave exactly as before: an unset binding still raises `UndefVarError` rather than `UndefRefError`, the modify loop still validates each candidate value against the (fixed) partition through `jl_check_binding_assign_value`, and the result types are unchanged. The only reordering is that `jl_checked_replace` now computes the return type after the loop rather than before it. This gives the binding loops a place to diverge from the field ones in later commits. Assisted-by: Claude Code (Opus 4.8, Opus 5, Fable 5) and OpenAI Codex Co-authored-by: Keno Fischer <Keno@users.noreply.github.com>
Assisted-by: Codex (GPT-5.6 Luna)
Assisted-by: Codex (GPT-5.6 Luna)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Julia
bb92f91a6069fbc08ecc1346b8baf99b3bf84a92→53efe7eca879b513b199718847e6f30e7c86ff70.Reviewed 53efe7e against its first parent, the existing Joolia port, and the merged tree. It is a runtime-only refactor of global atomic RMW loops with no zero-origin semantic change. No source or test adaptation is needed; suitable for a draft PR and CI after required native validation.
Draft for human review. Automatic merging is disabled.
The upstream history is preserved in a merge commit; any Joolia adaptations are committed separately. The publisher explicitly dispatches Joolia CI on this branch; inspect its result before merging.
Review record:
contrib/upstream-sync/reports/53efe7eca879b513b199718847e6f30e7c86ff70.json.Incoming commits:
53efe7eca879b513b199718847e6f30e7c86ff70— module: give the global RMW store helpers their own loops [NFC] (change 63250)Merge integrated batches with a merge commit, never squash/rebase, to preserve the upstream ancestry.
Passing CI covers only
contrib/ci/coverage.json; it does not certify the entire port.