Repository navigation
upstream: Review Julia through bb92f91a6069 - #13
Merged
github-actions[bot] merged 3 commits intoSep 19, 2026
Merged
Conversation
…3249) Split the "not a writable global" diagnostics out of `jl_check_binding_currently_writable` into a helper. Assisted-by: Claude Code (Opus 4.8, Fable 5) and OpenAI Codex Co-authored-by: Keno Fischer <Keno@users.noreply.github.com>
Assisted-by: Codex (GPT-5.6 Luna)
Assisted-by: Codex (GPT-5.6 Luna)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Julia
9bc48db402eefac7c613d60c4f54d7d0fef5738a→bb92f91a6069fbc08ecc1346b8baf99b3bf84a92.Reviewed the first-parent diff, Joolia’s pre-batch code, and the resulting merged tree. This is a behavior-preserving refactor of binding-write diagnostics; no zero-origin adaptation or test edit is needed.
Draft for human review. Automatic merging is disabled.
The upstream history is preserved in a merge commit; any Joolia adaptations are committed separately. The publisher explicitly dispatches Joolia CI on this branch; inspect its result before merging.
Review record:
contrib/upstream-sync/reports/bb92f91a6069fbc08ecc1346b8baf99b3bf84a92.json.Incoming commits:
bb92f91a6069fbc08ecc1346b8baf99b3bf84a92— module: factor outjl_binding_not_writable_error[NFC] (change 63249)Merge integrated batches with a merge commit, never squash/rebase, to preserve the upstream ancestry.
Passing CI covers only
contrib/ci/coverage.json; it does not certify the entire port.