Repository navigation
fix(retro): verify host binding before source reuse - #302
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the source-worktree reuse guidance and evaluation updates.
No open issues 🎉
What changed in this PR
This PR strengthens /retro source-worktree reuse and delivery guidance by requiring host session bindings to agree with Git state and the intended PR destination.
Changes:
- Requires verified host retargeting or patch preservation and coordination of a fresh source session/worktree, while retaining ordinary Git-only reuse.
- Adds one synthetic stale-host-binding eval scenario without changing existing cases, scoring, or guards.
- Extends contract and eval-inventory assertions to cover the new guidance.
| File | Description |
|---|---|
skills/retro/test/skill.test.mjs |
Adds assertions for host-binding guidance and the new eval scenario. |
skills/retro/SKILL.md |
Defines host-binding verification and safe recovery before reuse or delivery. |
skills/retro/evals/retro/eval.yaml |
Adds a stale-binding scenario covering preservation, consent, and refusal handling. |
Review effort: Balanced
Owner
Author
|
Related-issue inventory: none. Verified closing links, PR description, task/handoff scope, and the complete PR conversation; no related issues were identified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
node --test --test-concurrency=1 .\skills\retro\test\*.test.mjs .\test\retro-eval.test.mjs- 19 passed.node --check .\skills\retro\test\skill.test.mjs- passed..\.github\tools\vally\node_modules\.bin\vally.cmd lint .\skills\retro- passed, 2/2 checks..\.github\tools\vally\node_modules\.bin\vally.cmd lint --eval-spec .\skills\retro\evals\retro\eval.yaml --strict- valid.git diff --check- passed; new contract/inventory checks failed against the pre-fix source as expected.No paid/model-backed/live evaluation was run; static checks do not establish agent-behavior improvement. No runtime, README, version, or installation changes. Merge requires separate final confirmation.