Skip to content

fix(retro): verify host binding before source reuse - #302

Merged
jongio merged 1 commit into
mainfrom
jongio-upgraded-garbanzo
Nov 18, 2026
Merged

jongio merged 1 commit into
mainfrom
jongio-upgraded-garbanzo

Conversation

@jongio

@jongio jongio commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • Require host context, Git branch/head, and intended PR destination to agree before source-worktree reuse or delivery when the host binds a session to a branch/PR.
  • Allow verified supported retargeting; otherwise preserve a portable patch and coordinate a fresh source session/worktree without branch switching, raw-state edits, or refusal bypasses. Keep ordinary terminal/Git-only reuse allowed when no host binding applies.
  • Add exactly one synthetic stale-host-binding stimulus and only the related contract/inventory assertions. Existing cases, defaults, scoring, and guards remain unchanged.

Validation

  • node --test --test-concurrency=1 .\skills\retro\test\*.test.mjs .\test\retro-eval.test.mjs - 19 passed.
  • node --check .\skills\retro\test\skill.test.mjs - passed.
  • .\.github\tools\vally\node_modules\.bin\vally.cmd lint .\skills\retro - passed, 2/2 checks.
  • .\.github\tools\vally\node_modules\.bin\vally.cmd lint --eval-spec .\skills\retro\evals\retro\eval.yaml --strict - valid.
  • git diff --check - passed; new contract/inventory checks failed against the pre-fix source as expected.
  • Static scope/parity check - exactly three changed source files, exactly one added stimulus, and all prior eval content byte-unchanged.

No paid/model-backed/live evaluation was run; static checks do not establish agent-behavior improvement. No runtime, README, version, or installation changes. Merge requires separate final confirmation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the source-worktree reuse guidance and evaluation updates.

No open issues 🎉

What changed in this PR

This PR strengthens /retro source-worktree reuse and delivery guidance by requiring host session bindings to agree with Git state and the intended PR destination.

Changes:

  • Requires verified host retargeting or patch preservation and coordination of a fresh source session/worktree, while retaining ordinary Git-only reuse.
  • Adds one synthetic stale-host-binding eval scenario without changing existing cases, scoring, or guards.
  • Extends contract and eval-inventory assertions to cover the new guidance.
File Description
skills/​retro/​test/​skill.test.mjs Adds assertions for host-binding guidance and the new eval scenario.
skills/​retro/​SKILL.md Defines host-binding verification and safe recovery before reuse or delivery.
skills/​retro/​evals/​retro/​eval.yaml Adds a stale-binding scenario covering preservation, consent, and refusal handling.

Review effort: Balanced

@jongio

jongio commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Related-issue inventory: none. Verified closing links, PR description, task/handoff scope, and the complete PR conversation; no related issues were identified.

@jongio
jongio merged commit b5cfe54 into main Nov 18, 2026
8 checks passed
@jongio
jongio deleted the jongio-upgraded-garbanzo branch November 18, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants