Repository navigation
fix(git-tidy): preserve integrated work recommendations - #301
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the integrated-work classification changes.
No open issues 🎉
What changed in this PR
Refines git-tidy’s integrated-work classification following #299, preserving useful recommendations without changing cleanup safeguards, eligibility, or approval requirements.
Changes:
- Reports
integrated-work-retainedinstead of incomplete evidence when proven integrated work has no remaining change units but must be retained. - Preserves
resumeand the allowedkeep-savereview transition when a complete group still contains stash change units. - Adds focused regression coverage and documents the group-wide recommendation behavior.
| File | Description |
|---|---|
skills/git-tidy/test/triage.integration.test.mjs |
Covers retained integration reasons and grouped-stash resume/save behavior. |
skills/git-tidy/scripts/lib/triage-policy.mjs |
Adjusts integrated-group recommendations and retention reasons. |
skills/git-tidy/references/evidence-model.md |
Documents whole-group change-unit checks and unchanged cleanup safeguards. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #299, addressing its two post-merge Copilot findings.
integrated-work-retainedwhen complete integration proof leaves an empty work item retained by safeguards, rather than claiming evidence is incomplete.resumerecommendation and monotonekeep-savereview transition when a grouped stash still has unique change units.Only the policy, focused integration tests, and evidence-model reference change. No cleanup actions or skill installation are included.
Validation
node --test --test-concurrency=1 --experimental-test-coverage --test-coverage-include="**/triage-policy.mjs" --test-name-pattern="squash|proven protected integrated work|integrated branch preserves resume|stash components|exact duplicate stash|every recommendation transition|applyReview rejects the whole batch" skills\git-tidy\test\triage.integration.test.mjs skills\git-tidy\test\classify.test.mjs: 8 passed, 0 failed.node --test --test-concurrency=1 --experimental-test-coverage --test-coverage-lines=80 --test-coverage-functions=80 --test-coverage-branches=80 skills\git-tidy\test\*.test.mjs: 286 passed, 0 failed, no skips. Overall coverage: 95.54% lines, 89.95% branches, 98.11% functions. Touched policy: 98.17% lines, 95.72% branches, 100% functions.lint skills\git-tidyandlint --eval-spec skills\git-tidy\evals\git-tidy\eval.yaml --strict: passed. No model-backed evals run.npm run build --prefix site: passed, including catalog performance bounds.node --checkon the changed JavaScript andgit diff --check: passed.node --test --test-concurrency=1 test\*.test.mjsfinished with 79 passed, 1 skipped, 1 failed. The unchanged nested PR-statusline native Windows attention-helper test returned{"type":"unavailable","message":"Access is denied"}atextensions\pr-statusline\test\attention.test.mjs:1050. No helper, host-permission, or unrelated code changes were made. Hosted CI must pass before merge readiness.Related issues and delivery boundaries
No related issues were identified in the handoff or the original PR's closing links; #299 is a pull request, not an issue.
Merge requires a separate final decision on the reviewed full head. Repository auto-deletion of merged head branches conflicts with the current no-cleanup restriction and must be explicitly resolved before any merge. No GitHub auto-merge or Agent merge is enabled by this work.