Repository navigation
test(pr): cover draft readiness with existing human feedback - #300
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the added PR-readiness regression case.
No open issues 🎉
What changed in this PR
Adds a synthetic regression case to the PR skill’s evaluation suite for making an approved draft PR ready while existing human feedback remains unresolved.
Changes:
- Checks that plans address known human findings, preserve open questions, and report outstanding work without assuming merge consent or waiting for post-readiness reviews.
- Adds the case to the expected inventory; existing cases, shared guards, scoring weights, and runtime code remain unchanged.
| File | Description |
|---|---|
skills/pr/test/skill.test.mjs |
Adds the new scenario to the expected evaluation-case list. |
skills/pr/evals/pr/eval.yaml |
Defines the scenario, behavioral rubric, and execution guards. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
node --test --test-concurrency=1 --test-name-pattern="eval spec covers private repo reviewer rules" skills/pr/test/skill.test.mjs(1 test; case inventory, mandatory guards, decisive weights).node --test --test-concurrency=1 skills/pr/test/eval-gates.test.mjs(10 tests)..github/tools/vally/node_modules/.bin/vally lint --eval-spec skills/pr/evals/pr/eval.yaml --strict.git diff --check.