Deny framing on all responses to prevent clickjacking - #1
Open
Fyko wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a global middleware that sets
Content-Security-Policy: frame-ancestors 'none'andX-Frame-Options: DENYon every response.Why
The viewer shell renders the sharing controls (make public/private, manage access). Right now nothing stops another origin from embedding the shell in an iframe, so a malicious page could clickjack those controls — overlay an invisible shell over bait UI and trick a logged-in user into flipping a doc public.
There were no anti-framing headers anywhere in the worker.
Why it's safe as a blanket header
The only iframe the app renders is the document itself, via
iframe.srcdoc.srcdoccontent isn't fetched by URL, soframe-ancestorsnever applies to it — legit document rendering is unaffected. Nothing else in the app frames its own pages by URL.Test
Added an assertion to the health route test that both headers are present on a response.
48 passedlocally, typecheck clean.