docs: add FORK.md documenting fork overlay and origin-only push boundary - #4
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Document the jokim1 fork model, origin-only PR boundary, rebase ownership, and diverged-checkout expectations so every worktree shares the same fork rules.
jokim1
added a commit
that referenced
this pull request
Aug 25, 2026
…ary (#4) * docs: add FORK.md for origin-only overlay rules Document the jokim1 fork model, origin-only PR boundary, rebase ownership, and diverged-checkout expectations so every worktree shares the same fork rules. * no-mistakes(review): Clarify immutable upstream write boundary * no-mistakes(test): Fix fork policy and documentation audience classification
jokim1
added a commit
that referenced
this pull request
Aug 25, 2026
…ary (#4) * docs: add FORK.md for origin-only overlay rules Document the jokim1 fork model, origin-only PR boundary, rebase ownership, and diverged-checkout expectations so every worktree shares the same fork rules. * no-mistakes(review): Clarify immutable upstream write boundary * no-mistakes(test): Fix fork policy and documentation audience classification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Create a tracked FORK.md at the repository root documenting how this fork works, so every agent in any worktree finds the fork rules without restating them in each brief.
Content requirements (docs-only; distill; do not copy captain-private policy or approval mechanics):
Constraints: PR target = origin fork (jokim1/firstmate) ONLY; upstream (kunchenguid/firstmate) is FORBIDDEN for any write. Captain approved this as a fork-only new-file docs patch; usual adversarial panel for fork-queue candidates waived (captain, 2026-08-15). Follow firstmate-coding-guidelines / repo style (one sentence per line, plain dashes, no agent co-authors).
Context for this relaunch: branch was rebased onto green origin/lila-main after CI-restoration PRs #5/#6/#7 landed; obsolete pre-existing-CI-fix commits that conflicted with those landings were dropped because main already covers them. Prior review ask-user about issues-only wording was answered and applied. Re-validate the existing open PR #4 through green CI.
What Changed
FORK.mdat the repo root that documents the fork model:origin(jokim1/firstmate) vsupstream(kunchenguid/firstmate), thelila-mainoverlay branch (upstreammainplus a curated squash-commit patch stack, periodically rebased), and the rule that force-push is authorized only forlila-mainon the jokim1 fork.upstream/sanchithremotes; also cover the operator-private rebase owner, patch retire-when/conflict handling, and how checkouts recover after an overlay rebase rewrites commit IDs.FORK.mdindocs/documentation-audiences.jsonas anagent-runtimedoc so audience classification and local-link checks recognize it.Risk Assessment
✅ Low: Well-bounded docs-only change adding a single tracked FORK.md plus one audience-classification entry; content matches every required intent constraint, introduces no executable behavior, and the JSON stays valid.
Testing
I exercised the documentation-audience validation that CI itself runs — the structural checker (bin/fm-doc-audience-check.sh) and its test suite (tests/fm-documentation-audiences.test.sh) both pass, confirming FORK.md is registered and classified exactly once as an agent-runtime surface with all local links resolving. I mapped FORK.md's content against every required constraint in the intent (origin/upstream model, lila-main overlay and squash-patch stack, force-push authorized only for lila-main on the jokim1 fork, origin-only hard boundary with captain-gated upstream writes and disabled upstream/sanchith push URLs, rebase reconciliation naming data/patch-queue/rebase-lila-main.sh without private contents, retire-when patch drops, non-auto-resolved conflicts, and the checkout-divergence/reset-in-quiet-window guidance) and captured a rendered screenshot of the doc as the end-user surface. Scope is clean: only FORK.md and the audience inventory changed, AGENTS.md is untouched, and the file is 48 lines. PR #4 CI is passing with zero failures; at finalize time 8 of 12 checks were green and the remaining 4 broad behavior-serial suites were still running (no failures). No forbidden upstream writes occurred. Worktree left clean; evidence files kept in the dedicated evidence directory.
/var/folders/vx/kq2w6_xj1sq82jh1gtsjl0_m0000gn/T/no-mistakes-evidence/01M094BS1ZT2BEYX1XQ5RZ9RR6/FORK.md.preview.png)Evidence: Rendered FORK.md (HTML preview)
Evidence: Doc-audience checker output
Evidence: PR #4 CI checks
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
bin/fm-doc-audience-check.sh→ok surfaces=71 local_links=242(FORK.md classified exactly once as agent-runtime; all local links resolve)bash tests/fm-documentation-audiences.test.sh→ all 4 structural cases pass (exact-once classification, setup routing, required owner pointers, local-link resolution)Rendered FORK.md to HTML and captured a full-page screenshot to confirm the end-user doc surface and that all four required sections are presentgit diff --name-only cf49ebc..HEAD→ only FORK.md and docs/documentation-audiences.json changed; AGENTS.md not touched; FORK.md is 48 lines (within the ~40-70 target)gh-axi pr checks 4→ 8 passed, 0 failed (Lint, Test coverage guard, Repo invariants, Herdr, macOS Bash snapshot all green; 4 broad serial behavior suites still running with no failures)✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.