Promote Game Info and Player Info to nav-tab destinations

[JorenC]

Summary

• Adds "Game Info" and "Player Info" as first-class nav-tab destinations (bottom nav on mobile, icon sidebar on desktop) alongside Map/Orders/Chat, instead of only being reachable through the game dropdown menu.
• Extracts the nav-item computation out of GameDetailLayout into a new useGameNavItems hook (with tests) so it's shared and independently testable.
• Selecting "Map" on desktop now collapses the content column so GameMap fills the remaining space, since the map would otherwise be shown twice.
• GameDropdownMenu's onNavigateToGameInfo/onNavigateToPlayerInfo props are now optional and the dropdown no longer shows those entries from the two in-game screens (MapScreen, OrdersScreen) since they're reachable from the nav directly. The Home-screen dropdown (pre-phase games) is unaffected.

Test plan

• npx tsc -b --noEmit — clean
• npm run lint — clean
• npx vitest run src/hooks/useGameNavItems.test.tsx — 9/9 passing
• npx vitest run src/components/GameDropdownMenu.test.tsx — 5/5 passing (unaffected)
• Manual check of mobile bottom nav and desktop sidebar/map-focus behavior (screenshots below)

Screenshots

Desktop — before (/tmp/shots/before-desktop-orders.png): sidebar only has Map and Chat icons.

Desktop — after (/tmp/shots/after-desktop-orders.png): sidebar gains Game Info and Player Info icons.

Desktop — after, Map focused (/tmp/shots/after-desktop-map-focused.png): selecting Map collapses the content column so the map fills the screen.

Mobile — before (/tmp/shots/before-mobile-orders.png): bottom nav has 3 tabs (Map, Orders, Chat).

Mobile — after (/tmp/shots/after-mobile-orders.png): bottom nav has 5 tabs (Map, Orders, Chat, Game Info, Player Info).

🤖 Generated with Claude Code

https://claude.ai/code/session_01UxmTChkYBshN1yeZa2EHhi

[JorenC]

PR Review

I traced the back-navigation behavior change in GameInfoScreen/PlayerInfoScreen (dropping onNavigateBack/variant="secondary") against AppBar.tsx's default handling — it now matches Map/Orders' existing X → navigate("/") pattern, which is consistent given these are now peer nav tabs rather than sub-screens, not a regression. I also verified GameDropdownMenu's optional-prop conditional rendering doesn't break its other three callers (GameCard, Home/GameInfo, Home/PlayerInfo), which still pass both handlers unchanged. tsc -b --noEmit, lint, and the existing GameDropdownMenu test suite all pass clean.

No correctness bugs found — 0 blocking, 0 suggestion inline comments.

[github-actions]

Warning

WIP limit exceeded. There are now 10 open pull requests — the project target is 5 or fewer.

Please close or merge an existing PR before continuing with this one.

[netlify]

✅ Deploy Preview for diplicity-variant-creator canceled.

Name	Link
🔨 Latest commit	70f906a
🔍 Latest deploy log	https://app.netlify.com/projects/diplicity-variant-creator/deploys/6a624737a710ae0008656039

[JorenC]

Before and after screenshots.