Add Google Play badge to Login screen - #1092
Conversation
Adds a "Get it on Google Play" badge next to the existing App Store badge in both the desktop hero blurb and the mobile section below the login card. Gated on !isNativePlatform() only, so it's hidden inside both native apps and shown everywhere on web. Closes #1091 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F1t712RqWunRMBdqY9nnLW
|
Warning WIP limit exceeded. There are now 10 open pull requests — the project target is 5 or fewer. Please close or merge an existing PR before continuing with this one. |
✅ Deploy Preview for diplicity-variant-creator canceled.
|
johnpooch
left a comment
There was a problem hiding this comment.
PR Review
Adds a Google Play badge next to the existing Apple App Store badge on the Login screen (desktop hero + mobile section), gated on !isNativePlatform(). Verified the gating logic against isNativePlatform/isIosPlatform in utils/platform.ts: native iOS shows only the Apple badge, native Android shows neither (unchanged prior behavior), web shows both — matching the stated intent. Ran the test suite (Login.test.tsx, 7 passed), eslint, and tsc -b --noEmit locally on this branch — all clean.
0 inline comment(s) (0 blocking, 0 suggestion). No issues found.
Generated by Claude Code
|
This pull request has been inactive for 7 days and will be closed in 7 days unless there is further activity. If it is still being worked on, push a commit or leave a comment. Add the |
|
Still active — CI is green and the review left no blocking findings. Ready to merge whenever convenient. Generated by Claude Code |
What this PR does
Adds a "Get it on Google Play" badge next to the existing "Download on the App Store" badge on the Login screen, in both the desktop hero blurb and the mobile section below the login card. The new badge links to the Play Store listing and is gated on
!isNativePlatform()only, so it's hidden inside both native apps and shown on desktop web and mobile web — matching the Apple badge's markup and sizing (h-10,target="_blank",rel="noreferrer").Closes #1091
Checklist
/review-prskill depends on theghCLI, unavailable in this environment, so I did a manual pass instead)Generated by Claude Code