Skip to content

Add Google Play badge to Login screen - #1092

Open
johnpooch wants to merge 1 commit into
mainfrom
claude/dreamy-bell-4hek06
Open

Add Google Play badge to Login screen#1092
johnpooch wants to merge 1 commit into
mainfrom
claude/dreamy-bell-4hek06

Conversation

@johnpooch

Copy link
Copy Markdown
Owner

What this PR does

Adds a "Get it on Google Play" badge next to the existing "Download on the App Store" badge on the Login screen, in both the desktop hero blurb and the mobile section below the login card. The new badge links to the Play Store listing and is gated on !isNativePlatform() only, so it's hidden inside both native apps and shown on desktop web and mobile web — matching the Apple badge's markup and sizing (h-10, target="_blank", rel="noreferrer").

Closes #1091

Checklist

  • This PR does one thing — no unrelated fixes, refactors, or drive-by cleanups bundled in
  • I reviewed this PR's diff against the code philosophy in CLAUDE.md (the /review-pr skill depends on the gh CLI, unavailable in this environment, so I did a manual pass instead)
  • Tests cover the change
  • Screenshots taken confirming badge placement and visibility gating (desktop hero and mobile, logged out). Note: in this sandboxed environment the badge images themselves fail to load because Google's and Apple's image CDNs aren't in the network egress allowlist — this only affects local screenshotting, not production, where the same hosted Apple badge already renders fine.

Generated by Claude Code

Adds a "Get it on Google Play" badge next to the existing App Store
badge in both the desktop hero blurb and the mobile section below the
login card. Gated on !isNativePlatform() only, so it's hidden inside
both native apps and shown everywhere on web.

Closes #1091

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F1t712RqWunRMBdqY9nnLW
@github-actions

Copy link
Copy Markdown
Contributor

Warning

WIP limit exceeded. There are now 10 open pull requests — the project target is 5 or fewer.

Please close or merge an existing PR before continuing with this one.

@netlify

netlify Bot commented Jul 21, 2026

Copy link
Copy Markdown

Deploy Preview for diplicity-variant-creator canceled.

Name Link
🔨 Latest commit f72f62b
🔍 Latest deploy log https://app.netlify.com/projects/diplicity-variant-creator/deploys/6a5f69e974907100080f605a

@johnpooch johnpooch left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Adds a Google Play badge next to the existing Apple App Store badge on the Login screen (desktop hero + mobile section), gated on !isNativePlatform(). Verified the gating logic against isNativePlatform/isIosPlatform in utils/platform.ts: native iOS shows only the Apple badge, native Android shows neither (unchanged prior behavior), web shows both — matching the stated intent. Ran the test suite (Login.test.tsx, 7 passed), eslint, and tsc -b --noEmit locally on this branch — all clean.

0 inline comment(s) (0 blocking, 0 suggestion). No issues found.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 7 days and will be closed in 7 days unless there is further activity. If it is still being worked on, push a commit or leave a comment. Add the pinned label to exempt it permanently.

@github-actions github-actions Bot added the stale label Jul 29, 2026

Copy link
Copy Markdown
Owner Author

Still active — CI is green and the review left no blocking findings. Ready to merge whenever convenient.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Google Play badge to Login screen

2 participants