fixed sdl2compat bug when sdl3 is used on macOS builds - #5
Open
rathse wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
The game's streaming screen texture is now created explicitly as SDL_PIXELFORMAT_ARGB8888 | SDL_TEXTUREACCESS_STREAMING in src/gfx/gfx.c::gfxInitSDL() instead of being derived from the 8-bit palettized surface via SDL_CreateTextureFromSurface(). The per-frame update path in gfxUpdateSDL() — which already converts the surface to ARGB8888 and uploads it with SDL_UpdateTexture — remains unchanged.
Why it is necessary for compilation on macOS (tested with macOS 26.5 Tahoe / aarch64):
The actual formula for sdl2 in the package manager Homebrew uses a SDL2 compatibility API on top of SDL3.
Unlike real SDL2, which silently promotes a palettized surface to an ARGB8888 texture, this compatibility layer keeps it as INDEX8. This means that the per-frame upload of the ARGB8888 texture does not longer match the texture's pixel format. SDL accepts the call without raising an error, but the upload is dropped and the window remains blank white. Classic SDL2 (Linux/Windows) is not affected because it already used ARGB8888 internally for this texture, so the explicit request does no affect these builds.