Fix IntesisBox missing update callback and correct README examples#78
Merged
Conversation
IntesisBox never fired _send_update_callback on incoming CHN,1 state pushes, only once after the initial connect handshake. Consumers that rely purely on the callback (e.g. should_poll=False in a Home Assistant climate entity) would never see state changes after connecting, even though the underlying _devices dict stayed fresh in the background. IntesisHome and IntesisHomeLocal already fired the callback correctly on every push/poll cycle. Also fixes two README examples that no longer matched the API: add_callback() (method is add_update_callback()) and an await on get_power_state(), which is synchronous. Bump version to 2.0.3. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntesisBox never fired _send_update_callback on incoming CHN,1 state pushes, only once after the initial connect handshake. Consumers that rely purely on the callback (e.g. should_poll=False in a Home Assistant climate entity) would never see state changes after connecting, even though the underlying _devices dict stayed fresh in the background. IntesisHome and IntesisHomeLocal already fired the callback correctly on every push/poll cycle.
Also fixes two README examples that no longer matched the API: add_callback() (method is add_update_callback()) and an await on get_power_state(), which is synchronous.
Bump version to 2.0.3.