Composition collections in runtime detail view template#5334
Open
knstvk wants to merge 1 commit into
Open
Conversation
Generate a TabSheet in template-based detail views for entities that have composition *-to-many properties: the first "General" tab holds the form of single-value fields, and each composition collection gets a tab with a dataGrid (create/edit/remove via standard list actions that open the line entity's own detail view). Entities without composition collections render a plain formLayout as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Runtime view templates (#5225) generate list/detail views from
@DetailViewTemplatemetadata, but had a known limitation: composition collections were unsupported — a generated detail view only rendered single-value fields, with no way to view or edit a composition's child rows.What it does
When a
@DetailViewTemplateentity has composition*-to-manyproperties, the generated detail view now renders aTabSheet:dataGrid(create / edit / remove). Create/edit open the line entity's own detail view in a dialog, so line entities are expected to also carry@DetailViewTemplate.Entities without composition collections render a plain
formLayoutexactly as before.Implementation
ViewTemplateHelper#getCollectionProperties— returns composition*-to-manyproperties (associations and datatype collections excluded), honoringexcludeProperties.detail-template.ftl— adds a fetch-plan entry and a nested<collection>container per composition property, and a conditional<tabSheet>; collection-tab dataGrids uselist_create/list_edit/list_removewithopenMode=DIALOG.includeProperties).msg://references so captions resolve per-user at view-load time (the "General" tab uses a newviewTemplate.generalTabkey).