ci(snap): make snapcraft workflow iterable and add adopt-info - #19
Closed
jmelosegui wants to merge 1 commit into
Closed
ci(snap): make snapcraft workflow iterable and add adopt-info#19jmelosegui wants to merge 1 commit into
jmelosegui wants to merge 1 commit into
Conversation
Three related changes that let us debug snap-store packaging without
having to push a real release tag.
1. Workflow triggers
- Add workflow_dispatch so the workflow can be run manually
against any branch via the GitHub UI or `gh workflow run`.
- Add pull_request trigger filtered to snap/** and the workflow
file itself, so PRs that touch the snap config get automatic
build feedback.
- Tag-push trigger remains; snap-store upload is now gated on
refs/tags/v* so PR and dispatch builds stop at the build step.
- SNAP_VERSION falls back to 0.0.0-dev for non-tag runs so the
overlaid version string stays valid.
2. snap/snapcraft.yaml: add `adopt-info: git-sweep`
The previous v0.1.1 build run failed schema validation:
has-base.core22
Value error, Required field 'version' is not set and
'adopt-info' not used.
Snapcraft now requires an explicit adopt-info reference whenever
the version is set inside an override-build via `craftctl set
version=...`. Pointing it at the existing git-sweep part satisfies
the validator without changing how the version is computed.
Owner
Author
|
Superseded -- removing snap distribution entirely instead of fixing it. The script-based install on Linux is sufficient for now and a snap was not pulling its weight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the snap workflow runnable on any branch and clears the next schema validation error so v0.1.1's snap build path can finally make it past validation.
Workflow triggers
`snap/snapcraft.yaml`: add `adopt-info: git-sweep`
The v0.1.1 release run failed validation with:
```
has-base.core22
Value error, Required field 'version' is not set and 'adopt-info' not used.
```
Snapcraft now requires an explicit `adopt-info` reference whenever the version is set inside an `override-build` step via `craftctl set version=...`. Pointing it at the existing `git-sweep` part satisfies the validator without changing how the version is computed.
Test plan