feat(agents): migrate codex-review skill to the portable ai-agents/skills layout - #209
Merged
Conversation
… layout Move claude/skills/codex-review/ to ai-agents/skills/codex-review/ so it projects to Claude Code and Pi (asking Codex for a second opinion from a Pi session). Its ../_shared/review-rubric.md and ../_shared/dimensions.md links already resolved to the portable ai-agents/skills/_shared/ copy at the installed destination, so the move itself is the fix — no path rewrite needed. Exclude codex-review from the Codex CLI projection in setup.ps1/setup.sh: a Codex-on-Codex self-review has no target. Update SKILL-OWNERSHIP.md, claude/README.md, and the setup Pester/bash-dry-run tests to match. Closes #98 Refs: AB#98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves
codex-reviewfromclaude/skills/to the portableai-agents/skills/layout, per the #78 skills-portability audit. The only Claude coupling was the skill's own location: its../_shared/review-rubric.mdlink already resolved to the portable shared copy at every installed destination, so relocating the directory was the whole fix.Changes
ai-agents/skills/codex-review/SKILL.md: moved viagit mv(history preserved); precondition note extended to coversetup.sh -m codexand flag that Pi has nocodexMCP registration yet.setup.ps1/setup.sh: excludecodex-reviewfrom the Codex CLI projection (asking Codex to review itself has no target); it still projects to Claude Code and Pi.ai-agents/SKILL-OWNERSHIP.md,claude/README.md,codex/README.md: updated to reflect the new location and the Codex-exclusion rationale.tests/setup.Tests.ps1,tests/setup-sh.Tests.ps1: updated expected paths, added a Pi-projection assertion, kept the Codex-absence assertions.A follow-up
quick-reviewpass flagged that the Pi-side gap (nocodexMCP server registered there yet, so the skill projects but can't run) had no tracking reference. Filed #208 and referenced it in the three docs that disclose the gap.How to verify
72/72 and 25/25 (16 skipped, platform-gated) pass locally; analyzer clean.
Closes #98