feat(agents): rename rfc-bau-nsg-fw to rfc; add clone-derived both-scope, multi-PR, and fallback handling - #194
Merged
Merged
Conversation
…ope, multi-PR, and fallback handling Closes #129
…notes - Deserialize az pr show JSON before Select-Object -ExpandProperty repository (step 2) - Note the existing-RFC PATCH aside still requires step 7 go-ahead and step 9 read-back validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
rfc-bau-nsg-fwskill torfcand extends it to handle both-scope changes,multiple linked PRs, and an any-scope fallback, all clone-derived at runtime, never
hardcoded field values.
What changed
ai-agents/skills/rfc-bau-nsg-fw/toai-agents/skills/rfc/, withargs-routing (
/rfc bau firewall/nsgand friends implemented; other forms remainexplicit stop-stubs).
firewallandnsg) changes are classified and cloned from the mostrecent
BAU Firewall and NSG Rulesprior RFC, using the same exact-title-prefixdiscipline as the existing single-scope lookup.
ArtifactLinkrelation, and scopeis the union of all linked PRs' changed paths (each PR's own project/repo is resolved
separately, since firewall and NSG config can live in different repos).
firewall/NSG RFC of any scope, flagged as an inferred fallback in the confirmation
table rather than treated as an exact match.
convention, flagged as inferred rather than detected from a diff.
exact-title clone validation, unique per-run temp-file cleanup, and post-write
read-back validation.
in the per-PR repo lookup, a missing confirmation/read-back reminder on the documented
PATCH-existing-RFC workaround, and small wording clarity fixes.
No field value (SharePoint URLs, distribution lists, named individuals' contact info, or
static CAB picklist values) is written into the skill file anywhere. Every repeated
field still comes from cloning a real prior RFC at runtime.
Closes #129.
Verification
git diff --checkclean on every commit.high effort); two above-floor findings and three low-severity findings fixed.
live tenant access this environment doesn't have. The untracked prototype this skill
supersedes (
~/.claude/skills/rfc/) has already been deleted.