Repository navigation
fix(rules): accept an instance type set by a launch template in the stack - #19
Merged
Merged
Conversation
…tack The instance-type rule required InstanceType on every instance, so a correct template that took the type from its own launch template failed the gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COST_EC2_INSTANCE_TYPErequiredInstanceTypeon every instance, so a template whose instance took an allowed type from its own launch template failed the gate, and the agent had to repeat the type on the instance.An instance may now leave
InstanceTypeout when it launches from a launch template in the same stack (Refto it). The newCOST_INSTANCE_LAUNCH_TEMPLATE_TYPErequires every launch template in that stack to set a type, whichCOST_LAUNCH_TEMPLATE_INSTANCE_TYPEalready caps. A literal launch template ID (one outside the stack) still fails, and so does an oversized type set on the instance.Tests: 7 new rule cases, including a typed instance next to a typeless one, so the rule cannot be skipped by a mixed template.