Repository navigation
fix(validate): stop failing links that cannot be fetched - #18
Merged
Merged
Conversation
Placeholder URLs, reserved example domains, Console pages behind sign-in and sites that refuse automated requests were 12 of the 13 link failures seen in real authoring sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link stage failed labs on URLs it should not fetch. In a 90-session evaluation run, 12 of the 13 link failures were false positives: Console URLs behind sign-in, placeholder URLs the learner completes (
https://<api-id>...), reserved example domains, and re:Post answering 403 to curl.These URLs are now noted in the output and do not fail the gate. Real 4xx/5xx responses and the docs.aws.amazon.com soft 404 still fail. The notes do not mark the stage as skipped in
WAL_RUN_LOG.Test: a docs-only copy whose links are all placeholders, example domains or Console pages passes without network access, with one note per URL.