Skip to content

fix(validate): stop failing links that cannot be fetched - #18

Merged
jhermesn merged 1 commit into
mainfrom
fix/link-check-false-positives
Nov 5, 2026
Merged

jhermesn merged 1 commit into
mainfrom
fix/link-check-false-positives

Conversation

@jhermesn

@jhermesn jhermesn commented Nov 5, 2026

Copy link
Copy Markdown
Owner

The link stage failed labs on URLs it should not fetch. In a 90-session evaluation run, 12 of the 13 link failures were false positives: Console URLs behind sign-in, placeholder URLs the learner completes (https://<api-id>...), reserved example domains, and re:Post answering 403 to curl.

These URLs are now noted in the output and do not fail the gate. Real 4xx/5xx responses and the docs.aws.amazon.com soft 404 still fail. The notes do not mark the stage as skipped in WAL_RUN_LOG.

Test: a docs-only copy whose links are all placeholders, example domains or Console pages passes without network access, with one note per URL.

Placeholder URLs, reserved example domains, Console pages behind sign-in and
sites that refuse automated requests were 12 of the 13 link failures seen in
real authoring sessions.
@jhermesn jhermesn self-assigned this Nov 5, 2026
@jhermesn
jhermesn merged commit 45dc3b4 into main Nov 5, 2026
1 check passed
@jhermesn
jhermesn deleted the fix/link-check-false-positives branch November 5, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant