arm64: dts: qcom: x1-denali: add volume keys - #82
Merged
jglathe merged 2 commits intoSep 1, 2026
Conversation
Describe the Surface Pro 11 volume-up key on PM8550 GPIO 6 as an active-low wake-capable input with the required pull-up. This carries the hardware-verified volume-up portion of the original SP11 integration change without its obsolete pon_resin assumption. Link: 070c486 Signed-off-by: Leon Silcott <leon@boasi.io>
Describe the Surface Pro 11 volume-down key on PM8550 GPIO 8 as an active-low wake-capable input with the required pull-up. Enable gpio-keys autorepeat for the hardware rocker. The SP11 rocker is not wired through pon_resin, which remains disabled by the shared base description. Keep properties before child nodes so the gpio-keys node passes DT validation. Link: 247858b Link: e3b4bf3 Signed-off-by: Leon Silcott <leon@boasi.io>
This was referenced Aug 31, 2026
Owner
|
1 down, 41 to go. Thanks! |
Owner
|
This is a change that you can actually upstream (would recommend). It is isolated enough to practice the process. |
Author
I'm going to watch a YouTube video on this, then attempt it. Is there any other material you recommend I look at before starting the process? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pon_resinnode disabledScope and dependency
This is the first release-line topic extracted from the working
-sp11staging branch after #81. It is based directly onjg/ubuntu-qcom-x1e-7.2.yat032e174490d2and has no topic-PR dependency.The change is limited to
x1-microsoft-denali.dtsi. It does not carry the canceled CL4/PSCI experiment, USB changes, touch, pen, camera, audio, battery, or shared-driver changes from the staging history. The existing Denali firmware paths, rfkill setting, reserved GPIOs, and display backlight support are already present in the target branch and are therefore not replayed here.The volume-down staging replay had retained an obsolete
pon_resinoverride. #81 removed that replay omission from the staging branch; this release-line topic starts from the final intended state and never adds the override.Provenance
The two focused commits retain links to the original SP11 integration work:
The older
ooakleealias on the volume-down commits has been normalized to the contributor's signed identity,Leon Silcott <leon@boasi.io>.Validation
git diff --check 032e174490d2..HEADscripts/checkpatch.pl --strict --git 032e174490d2..HEAD: no errors or warningsubuntu_x1e_defconfigDT build withCHECK_DTBS=yand dtschema 2025.8qcom/x1e80100-microsoft-denali-oled.dtbbuilds successfullyqcom/x1p64100-microsoft-denali.dtbbuilds successfullypon_resinenablementCross-device impact
There are no shared-driver or non-Denali DT changes in this PR. Both supported Surface Pro 11 DTBs include the common Denali file and were validated above; other X1E/X1P devices do not include it.