[VC-43403] Add Local File output path mode#692
Merged
Conversation
wallrj-cyberark
force-pushed
the
VC-43403-fix-output-path-mode
branch
from
August 20, 2025 16:57
1c1dbc5 to
03c1459
Compare
wallrj-cyberark
marked this pull request as ready for review
August 20, 2025 17:03
wallrj-cyberark
force-pushed
the
VC-43403-fix-output-path-mode
branch
2 times, most recently
from
August 21, 2025 14:50
8a48f9e to
58f1c9c
Compare
wallrj-cyberark
changed the base branch from
master
to
revert-some-machinehub-mode
August 21, 2025 14:50
This was referenced Aug 21, 2025
wallrj-cyberark
marked this pull request as draft
August 21, 2025 20:43
inteon
approved these changes
Aug 22, 2025
wallrj-cyberark
force-pushed
the
VC-43403-fix-output-path-mode
branch
3 times, most recently
from
August 22, 2025 10:40
5306b24 to
bcb07ec
Compare
wallrj-cyberark
marked this pull request as ready for review
August 22, 2025 10:43
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj-cyberark
force-pushed
the
VC-43403-fix-output-path-mode
branch
from
August 22, 2025 11:11
bcb07ec to
4e5623d
Compare
inteon
approved these changes
Aug 22, 2025
wallrj-cyberark
commented
Sep 9, 2025
| "agent", | ||
| "--one-shot", | ||
| // TODO(wallrj): This should not be required when an `--input-file` has been supplied. | ||
| "--api-token=should-not-be-required", |
Contributor
Author
There was a problem hiding this comment.
The JIRA issue for this bug: https://venafi.atlassian.net/browse/VC-37133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Next I'd like to add a MachineHub mode:
Later I'll try and figure how we can allow multiple output modes.
Testing