refactor: use consistent parameter name for scope#138
Merged
Conversation
79f9a5f to
aaaa462
Compare
There was a problem hiding this comment.
Pull request overview
This PR standardizes CLI scope flag naming by moving affected commands from --scopes to --scope while preserving deprecated --scopes handling.
Changes:
- Renames OIDC flow config fields from
ScopestoScope. - Adds deprecated
--scopesaliases for affected commands. - Updates documentation and existing tests to use
--scope.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates run example to use --scope. |
| EXAMPLES.md | Updates usage examples to use --scope. |
| oidc/authorization_code.go | Renames authorization code flow config field to Scope. |
| oidc/client_credentials.go | Renames client credentials flow config field to Scope. |
| oidc/token_refresh.go | Renames token refresh flow config field to Scope. |
| cmd/authorization_code_cfg.go | Adds --scope and deprecated --scopes flag handling. |
| cmd/client_credentials_cfg.go | Adds --scope and deprecated --scopes flag handling. |
| cmd/token_refresh_cfg.go | Adds --scope and deprecated --scopes flag handling. |
| cmd/scopes_flag_deprecation.go | Adds shared deprecation warning/conflict detection helper. |
| cmd/authorization_code_cfg_test.go | Updates parser tests to use --scope. |
| cmd/client_credentials_cfg_test.go | Updates parser tests to use --scope. |
| cmd/token_refresh_cfg_test.go | Updates parser tests to use --scope. |
Ensures all subcommands consistently use `scope` as the parameter for accepting requested scope (and not the plural form `scopes` that was used previously by some subcommands).
aaaa462 to
f19a96c
Compare
jentz
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures all subcommands consistently use
scopeas the parameter for accepting requested scope (and not the plural formscopesthat was used previously by some subcommands).