Skip to content

[JENKINS-74212] Extract inine JavaScript from BuildGraph/index.jelly - #49

Open
yaroslavafenkin wants to merge 1 commit into
jenkinsci:masterfrom
yaroslavafenkin:JENKINS-74212
Open

[JENKINS-74212] Extract inine JavaScript from BuildGraph/index.jelly#49
yaroslavafenkin wants to merge 1 commit into
jenkinsci:masterfrom
yaroslavafenkin:JENKINS-74212

Conversation

@yaroslavafenkin

@yaroslavafenkin yaroslavafenkin commented Dec 11, 2024

Copy link
Copy Markdown

https://issues.jenkins.io/browse/JENKINS-74212

Other 25 violations that pop up in console in report-only mode of CSP plugin do not seem to affect the functionality. Everything seems to work just fine in restrictive mode.

I've tried to set ng-csp="no-unsafe-eval" on this line (ng-csp docs) but that had no visible effect on the number of violations. Nor on the functionality. Perhaps there are some features that I'm not aware of. My testing process is on the videos below.

Testing done

Before the change
After the change

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant