[JENKINS-74212] Extract inine JavaScript from BuildGraph/index.jelly - #49
Open
yaroslavafenkin wants to merge 1 commit into
Open
[JENKINS-74212] Extract inine JavaScript from BuildGraph/index.jelly#49yaroslavafenkin wants to merge 1 commit into
BuildGraph/index.jelly#49yaroslavafenkin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-74212
Other 25 violations that pop up in console in report-only mode of CSP plugin do not seem to affect the functionality. Everything seems to work just fine in restrictive mode.
I've tried to set
ng-csp="no-unsafe-eval"on this line (ng-csp docs) but that had no visible effect on the number of violations. Nor on the functionality. Perhaps there are some features that I'm not aware of. My testing process is on the videos below.Testing done
Before the change
After the change
Submitter checklist