Add typing hints - #272
Merged
Merged
Conversation
Also fix latent bugs where inbuffer was initialized as str instead of bytes, and adjust the corresponding test.
Add PEP 561 py.typed marker and .pyi stubs for the Rust-backed extensions: _ra, subr, repos, client, wc. Include them in package_data and MANIFEST.in so they are shipped with the wheel and sdist.
- ra_svn.py: fix _unparse -> _unpack typos, remove stale send_greeting call, fix b64encode() being passed a str instead of bytes, fix diff[args[0]] initialization to bytes instead of str - ra_svn.py: replace deprecated undocumented urlparse.split* helpers with urlparse.urlparse and manual netloc splitting - ra_svn.py: rename shadowed loop variables in log() so paths/revprops keep their declared types - ra.py: replace splittype with str.partition, drop urllib2 fallback - properties.py: drop try/except for urlparse (project is 3.10+) - Drop SocketServer fallback in ra_svn.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.