Skip to content

ci: restore pull request quality gates - #7

Merged
jeikl merged 1 commit into
jeikl:betafrom
xuan2261:fix/ci-pr-quality-gate-regression
Oct 5, 2026
Merged

jeikl merged 1 commit into
jeikl:betafrom
xuan2261:fix/ci-pr-quality-gate-regression

Conversation

@xuan2261

@xuan2261 xuan2261 commented Oct 5, 2026

Copy link
Copy Markdown

变更类型

  • 修复(bug / 回归)
  • 功能
  • 文档 / 规范 / 发版基建(不夹带进功能 PR;同类文档改动合并为一个 PR)
  • 是否为大功能更改、修复、更新

基于的分支与版本号

当前问题、对用户使用体验会产生什么问题或影响

After #6 landed, 8fd5b90e6 removed the pull_request trigger from build.yml, while ci.yml only ran on pushes. Current beta therefore had no workflow validating PR merge refs before merge.

The same streamlining also reduced installer integrity coverage to Ubuntu only, so PowerShell installer/wrapper regressions were no longer exercised on a hosted Windows runner.

A naive PR-trigger restore would also collide with the existing concurrency key for the normal beta -> main promotion path: both the beta push run and PR synchronize run could resolve to ci-beta, allowing the PR merge-ref run to be canceled.

解决方案

  • Restore pull_request CI for bases main and beta.
  • Separate concurrency by event and PR number:
    • push to beta: ci-push-beta
    • PR #N: ci-pull_request-pr-N
      This preserves stale-run cancellation within one PR/branch without letting a branch push cancel PR merge-ref validation.
  • Restore the installer integrity matrix on both ubuntu-latest and windows-latest.
  • Keep build.yml tag/workflow-dispatch only; this PR does not reintroduce heavyweight release builds on every PR.

提交清单(组内独立、可单独回退)

提交 作用 可否单独 revert
8e10b47ed Restore PR CI, event-safe concurrency, and Windows installer coverage Yes

每项提交引起的变化和影响面

Only .github/workflows/ci.yml changes. No Rust, WebUI, installer implementation, release artifact, or runtime behavior is modified.

自检(与 CI 相同的命令)

  • cargo fmt -- --check — N/A, no Rust changes; intentionally not run.
  • cargo clippy --workspace --all-targets — N/A, no Rust changes; intentionally not run.
  • cd webui && npm run build — N/A, no frontend changes.
  • node scripts/check-version-consistency.js — PASS: 7.1.53-beta.10 across core shipping manifests.
  • python scripts/test_installers.py — PASS on Windows: 12 tests OK, 2 POSIX-only cases skipped as designed; restored Ubuntu CI covers those paths.
  • Workflow YAML parse — PASS.
  • git diff --check / staged diff check — PASS.
  • Independent read-only review — CLEAN after fixing the push/PR concurrency collision.

署名

xuan2261

Co-Authored-By: JeikCode code@jeikcode.top

Restore PR CI on main/beta, keep push/PR concurrency isolated, and reinstate Windows installer integrity coverage.

Co-Authored-By: JeikCode <code@jeikcode.top>
@jeikl
jeikl merged commit 0466218 into jeikl:beta Oct 5, 2026
5 checks passed
@jeikl

jeikl commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Thank u,I will publish the main version soon because the beta version has any frontend problem need to be solved ,you can trace the progress in the beta version !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants