ci: restore pull request quality gates - #7
Merged
Merged
Conversation
Restore PR CI on main/beta, keep push/PR concurrency isolated, and reinstate Windows installer integrity coverage. Co-Authored-By: JeikCode <code@jeikcode.top>
Owner
|
Thank u,I will publish the main version soon because the beta version has any frontend problem need to be solved ,you can trace the progress in the beta version ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更类型
基于的分支与版本号
beta@f3eea9b9bc9d17e42856b568b072b782971338cb8fd5b90e6.当前问题、对用户使用体验会产生什么问题或影响
After #6 landed,
8fd5b90e6removed thepull_requesttrigger frombuild.yml, whileci.ymlonly ran on pushes. Currentbetatherefore had no workflow validating PR merge refs before merge.The same streamlining also reduced installer integrity coverage to Ubuntu only, so PowerShell installer/wrapper regressions were no longer exercised on a hosted Windows runner.
A naive PR-trigger restore would also collide with the existing concurrency key for the normal
beta -> mainpromotion path: both thebetapush run and PR synchronize run could resolve toci-beta, allowing the PR merge-ref run to be canceled.解决方案
pull_requestCI for basesmainandbeta.ci-push-betaci-pull_request-pr-NThis preserves stale-run cancellation within one PR/branch without letting a branch push cancel PR merge-ref validation.
ubuntu-latestandwindows-latest.build.ymltag/workflow-dispatch only; this PR does not reintroduce heavyweight release builds on every PR.提交清单(组内独立、可单独回退)
8e10b47ed每项提交引起的变化和影响面
Only
.github/workflows/ci.ymlchanges. No Rust, WebUI, installer implementation, release artifact, or runtime behavior is modified.自检(与 CI 相同的命令)
cargo fmt -- --check— N/A, no Rust changes; intentionally not run.cargo clippy --workspace --all-targets— N/A, no Rust changes; intentionally not run.cd webui && npm run build— N/A, no frontend changes.node scripts/check-version-consistency.js— PASS: 7.1.53-beta.10 across core shipping manifests.python scripts/test_installers.py— PASS on Windows: 12 tests OK, 2 POSIX-only cases skipped as designed; restored Ubuntu CI covers those paths.git diff --check/ staged diff check — PASS.署名
xuan2261
Co-Authored-By: JeikCode code@jeikcode.top