Repository navigation
LLM-741: memory-api listens on 127.0.0.1 only - #377
Merged
Merged
Conversation
The API listened on every interface (*:3100); only UFW kept the port off the internet. The connector login rate limit trusts the X-Forwarded-For hop nginx appends, so a direct request could forge its client address. Bind to HOST (default 127.0.0.1), set from the new memory_api_host Ansible var through the env file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM-741
The API listened on every interface (
*:3100); only UFW kept the port off the internet. The connector login rate limit (LLM-733) trusts theX-Forwarded-Forhop nginx appends, so a request that reached :3100 directly could forge its client address.server.jsbinds toMEMORY_API_HOST, default127.0.0.1.memory_api_host: 127.0.0.1(group_vars), written to/etc/memory-api/env. The env task already notifiesRestart memory-api.Checked on the VPS: all live connections to :3100 come from 127.0.0.1 (nginx, salem engine); no config uses
localhost:3100or[::1]:3100.code_review: no blocking issue; renamed
HOST→MEMORY_API_HOSTon its advice.Agent: Home
🤖 Generated with Claude Code