Skip to content

Fix: Do a shallow code review of the app code. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
agent-foreman-serverless wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix: Do a shallow code review of the app code. #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/src/main/java/com/barebone/app/ForgotPassword.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@ class ForgotPassword : AppCompatActivity() {
resources.getString(R.string.defaultValue)
)
val forgotPasPhrase: TextView = findViewById(R.id.enterMobileNumber)
// Use takeLast instead of a fixed subSequence(6, 10) range: stored mobile numbers
// shorter than 10 characters (e.g. bad data, or the "null" default fallback) would
// otherwise throw StringIndexOutOfBoundsException as soon as this screen opens.
val sourceString = "Enter your mobile number ending with " + "<b>" + "******${
actualMobileNumber.toString().subSequence(6, 10)
actualMobileNumber.orEmpty().takeLast(4)
}" + "</b>"
forgotPasPhrase.text = Html.fromHtml(sourceString)

Expand Down