Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/MiniCron.Tests/MiniCronTests.EventInvocationOutsideLock.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public async Task JobRegistry_JobAdded_InvokedOutsideLock_AllowsConcurrentReads(
{
var registry = new JobRegistry();
var eventHandlerStarted = new TaskCompletionSource<bool>();
var eventHandlerCanComplete = new TaskCompletionSource<bool>();
using var eventHandlerCanComplete = new ManualResetEventSlim(false);
var getJobsCompleted = new TaskCompletionSource<bool>();

// Subscribe to JobAdded with a long-running handler
Expand All @@ -22,7 +22,7 @@ public async Task JobRegistry_JobAdded_InvokedOutsideLock_AllowsConcurrentReads(
eventHandlerStarted.SetResult(true);
// Simulate a slow event handler (e.g., logging to database)
// Block synchronously until signaled
eventHandlerCanComplete.Task.GetAwaiter().GetResult();
eventHandlerCanComplete.Wait();
};

// Schedule a job (which will trigger JobAdded event)
Expand All @@ -47,7 +47,7 @@ public async Task JobRegistry_JobAdded_InvokedOutsideLock_AllowsConcurrentReads(
await Task.WhenAll(getJobsCompleted.Task.WaitAsync(TimeSpan.FromSeconds(5)), getJobsTask);

// Now allow event handler to complete
eventHandlerCanComplete.SetResult(true);
eventHandlerCanComplete.Set();
await scheduleTask;
}

Expand All @@ -61,14 +61,14 @@ public async Task JobRegistry_JobRemoved_InvokedOutsideLock_AllowsConcurrentRead
var jobId = registry.ScheduleJob("* * * * *", () => { });

var eventHandlerStarted = new TaskCompletionSource<bool>();
var eventHandlerCanComplete = new TaskCompletionSource<bool>();
using var eventHandlerCanComplete = new ManualResetEventSlim(false);
var getJobsCompleted = new TaskCompletionSource<bool>();

// Subscribe to JobRemoved with a long-running handler
registry.JobRemoved += (_, _) =>
{
eventHandlerStarted.SetResult(true);
eventHandlerCanComplete.Task.GetAwaiter().GetResult();
eventHandlerCanComplete.Wait();
};

// Remove the job (which will trigger JobRemoved event)
Expand All @@ -92,7 +92,7 @@ public async Task JobRegistry_JobRemoved_InvokedOutsideLock_AllowsConcurrentRead
await Task.WhenAll(getJobsCompleted.Task.WaitAsync(TimeSpan.FromSeconds(5)), getJobsTask);

// Allow event handler to complete
eventHandlerCanComplete.SetResult(true);
eventHandlerCanComplete.Set();
await removeTask;
}

Expand All @@ -106,14 +106,14 @@ public async Task JobRegistry_JobUpdated_InvokedOutsideLock_AllowsConcurrentRead
var jobId = registry.ScheduleJob("* * * * *", () => { });

var eventHandlerStarted = new TaskCompletionSource<bool>();
var eventHandlerCanComplete = new TaskCompletionSource<bool>();
using var eventHandlerCanComplete = new ManualResetEventSlim(false);
var getJobsCompleted = new TaskCompletionSource<bool>();

// Subscribe to JobUpdated with a long-running handler
registry.JobUpdated += (_, _) =>
{
eventHandlerStarted.SetResult(true);
eventHandlerCanComplete.Task.GetAwaiter().GetResult();
eventHandlerCanComplete.Wait();
};

// Update the job schedule (which will trigger JobUpdated event)
Expand All @@ -138,7 +138,7 @@ public async Task JobRegistry_JobUpdated_InvokedOutsideLock_AllowsConcurrentRead
await Task.WhenAll(getJobsCompleted.Task.WaitAsync(TimeSpan.FromSeconds(5)), getJobsTask);

// Allow event handler to complete
eventHandlerCanComplete.SetResult(true);
eventHandlerCanComplete.Set();
await updateTask;
}

Expand Down