🐛 export: fix burn-in caption path escaping on Windows - #7
Merged
Merged
Conversation
escape_filter_path emitted a double backslash before the drive colon
('C\:/...'), which the ffmpeg option parser de-escapes to a bare
backslash before a real separator — the quoted value splits mid-path and
the subtitles filter fails with 'No option name near ...' on ffmpeg 8.1.
Inside the single-quoted value the parser strips exactly one escape
level, so emit a single backslash ('C\:/...'), verified to parse and
render on ffmpeg 8.1.2. Also emit '\'' for an embedded single quote.
Co-Authored-By: Jean de Dieu HAGENIMANA <jdhagena77@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixes burn-in caption exports failing on Windows paths.
escape_filter_pathemittedfilename='C\\:/...'(double backslash before the drive colon). The ffmpeg option parser strips exactly one escape level inside a single-quoted value, so\\:de-escapes to a bare\followed by a real:separator — the value splits mid-path and the filter fails (No option name near '/Users/...'). Everycaption_mode=burn-inexport hit this on ffmpeg 8.1.2.Now emits
C\:/...(single backslash) — verified to parse and render on ffmpeg 8.1.2. Same fix applied to the embedded-quote escape (\'not\\'). Confirmed during chunked-export E2E testing where the identical failure reproduced on the pre-existing single-pass path (not chunked-specific).🎯 Type of Change
🧪 Validation & Testing
cargo fmt --checkpassescargo clippy --lib -- -D warningspassescargo checkpasses'C\:/path'(single backslash, quoted) parses and renders;'C\\:/path'(previous output) fails to parsecargo test— cannot link locally under windows-gnu (pre-existing GNU ld ordinal limit); covered by CI:escape only affects drive letters); Unix paths unaffected (no:to escape)📋 Checklist
CONTRIBUTING.mdLink to Devin session: https://app.devin.ai/sessions/52c7ba7f829f4aecbefa2f889efc8dc5
Open in Devin Desktop: https://app.devin.ai/desktop/session/52c7ba7f829f4aecbefa2f889efc8dc5?variant=devin
Requested by: @jeandedieuH