Repository navigation
Remove haptic feedback and verify General Settings in Tart - #105
Merged
Merged
Conversation
jdylanmc
marked this pull request as ready for review
October 2, 2026 08:36
This was referenced Oct 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#50: remove haptics, keep the interactions
Changes
Adds
general-haptics-removed, sharing a bounded two-pane Settings capture implementation with Notifications. Both scenarios preserve exact identity, real overlapping scroll captures, output assertions and fail-closed export checks; existing eight registrations remain intact.Two visible General labels initially failed pixel alignment because Vision's glyph bounds began four pixels before their native frames. A narrowly measured four-pixel leading allowance fixes those two labels only; exact text, vertical alignment, visibility and missing-output failures remain checked, including five-pixel rejection controls.
Validation and provenance
3c94d451c806024d83ac6ce25cd8b2f6641634a2: app 188, helper 69, workflow contracts 170, PR policy 22, Python 292, oracle 220; standalone harness built. Existing non-serious lint warnings retained.3507accfab56946de9bc74354adeae142a9c1cea, executablee652e9e8ee5f6fea950230571e8d7daae52545602f313229d7d111537b4d85dc. Production trees are unchanged at final harness head3c94d45.8844ddfff2ea42cdefc04ec0d3172aa439942d37, executable9896a6ffb6025a5b69aeae65aeec512b1eeda8677ce30b1dc8c38abad58703a0.3c94d451c806024d83ac6ce25cd8b2f6641634a2completed successfully without retry, including the three macOS build lanes and all CodeQL analyses.Limits
Tart proves the registered UI/output scenarios, not physical trackpad feedback or whole-app coverage. Source-removal contracts prove no haptic actuator remains in the product; live media, Shelf and Calendar interaction coverage remains separate. The app is Developer ID signed for guest testing, not notarized or released. No host app replacement or privacy changes.