Skip to content

Grow test coverage, starting with Shared/ #7

Open

Description

@jdylanmc

Want

Test the small parts that can fail quietly. The headless UI suite does not replace these tests.

Parent: #14. Product root: #13. Priority: P1, unchanged.

Already done

Implemented in draft, not merged

PR #109, head
2c482c32c9d8369f1aa2c99dc4ba7ba394ef8dac, adds real Foundation-pipe behavior
tests and fixes cancellation/descriptor lifetime. One demand-driven read owner
rejects new work after close and defers physical disposal until quiescence.
Parsing policy and media/Lunar consumer wiring are preserved.

Independent final review and all declared local gates passed: full app suite
220 cases (30 new stream plus two new wire cases over the 188-case base).
Separate targeted lifetime coverage: 34 selected cases x 10 = 340 passes.
Recorded-head hosted checks passed before the runner merge. These are unit/contract results, not
live producer/helper recovery proof.

The exact signed Shared candidate from head
2c482c32c9d8369f1aa2c99dc4ba7ba394ef8dac has now passed the merged
#108 harness's full registered nine-case Settings suite. The final protected
runner repeated that suite on two fresh headless boots: 18/18 expected suite
outcomes, plus two separate admission cases; all before/after recording
preflights were true, with zero skips or additional consent. Candidate
executable 2a71f91a55882ca8dc7749bcae4529a2a29a4e2d187370efe0f7c031fc4bd656,
six code files/thirteen signatures, scoped preferences/data and cleanup were
verified. This removes the recorded full-registered-suite/runner blocker.

These are Settings/runner-preservation results on that exact candidate, not
live Now Playing/Lunar producer restart, helper reconnect or whole-app recovery
proof. The earlier qualified six-case smoke and failed native attempts remain
historical evidence; no failure was relabeled or rerun into success.

PR #109 remains unmerged. Its review/local checks and recorded-head hosted
results are preserved, but landing now requires fresh integration/head/base
checks against pocket after #108. The Shared implementation is not yet
merged coverage.

Still needed

  • Refresh Harden shared JSON stream cancellation and descriptor lifetime #109's integration/head/base readiness and land the implemented JSONLinesPipeHandler coverage and lifetime fix. Full registered Settings-suite evidence is now available; do not recreate the tests or count an unmerged draft as pocket coverage.
  • Give every shared type appropriate behavior/contract coverage. Selector names alone do not prove helper transport, reconnect or failure behavior.
  • Cover remaining provider, model and manager seams with owned fixtures, controlled clocks and explicit error assertions, not personal accounts/files.
  • Reconcile Calendar isolation test(calendar): isolate providers and selection state #97 when it lands. It is still unmerged; its 18 component cases are not current pocket coverage.
  • Keep app, helper and script checks distinct. No skipped/weakened test or percentage claim stands in for missing behavior evidence.

The coverage inventory records existing evidence and gaps. #18 owns additional native control/fixture support; feature tickets own installed-app scenarios.

Groomed 2026-10-01: still open. Source inspection at 547d659 supports this gap list; it is not a fresh test run or a claim of complete seam coverage.

Factual reconciliation after #108 merged into pocket at
b8b70228d82bd0e8b208c2e34b4c94f6670fd9b2 on 2026-10-04 UTC
(2026-10-03 evening EDT). Remaining issue/PR states, priorities and ownership
are unchanged. This update does not run tests, integrate branches, merge
other work, change permissions, install an app or publish a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agenticRepo setup for AI-assisted developmentarea:agentsNotch-pocket feature area: agentspriority:P1User-ranked: next

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions