Skip to content

Add Bootstrap 5 support - #9

Closed
henning-unicode wants to merge 7 commits into
jbox-web:masterfrom
henning-unicode:feature/bootstrap5
Closed

Add Bootstrap 5 support#9
henning-unicode wants to merge 7 commits into
jbox-web:masterfrom
henning-unicode:feature/bootstrap5

Conversation

@henning-unicode

Copy link
Copy Markdown

Initial Bootstrap 5 support. Should work for level 1 navigation with dropdown menus with one level. More levels, separators and other special cases need to be tested.

@henning-unicode henning-unicode changed the title WIP: Add Bootstrap 5 support Add Bootstrap 5 support Jan 9, 2026
@henning-unicode

Copy link
Copy Markdown
Author

@n-rodriguez I couldn't successfully test this with the example with all features in the Readme. Not sure if this is a problem with the new code, the example or the setup of the application I am testing it with. Feel free to test it out and review if you have time. Otherwise I will try to get the test of the different features running some time soon.

@henning-unicode

henning-unicode commented May 29, 2026

Copy link
Copy Markdown
Author

@n-rodriguez would be great if you could review this PR :) Tests are missing, but they also are missing for the Bootstrap 4 renderer... sorry there is still a bug, I try to fix is ASAP

@henning-unicode

Copy link
Copy Markdown
Author

@n-rodriguez it's ready for review now

@n-rodriguez

Copy link
Copy Markdown
Member

Thanks for this contribution! Bootstrap 5 support has just landed on master in commit 13c020a — a full renderer (bootstrap5.rb / rendered_item5.rb) registered as :bootstrap5, with dropdown menus, dividers, headers, split toggles and parity characterization specs, plus README/CHANGELOG updates (version bumped to 1.4.0). Closing this PR as the feature is now implemented. Thanks again for kicking it off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants