fix&improve youtube-dl - #14
Conversation
jbergknoff
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
I'm not a fan of leaving the version unpinned. If somebody looks at the Dockerfile right now, they see that it's hopelessly out of date, and don't bother. If the version wasn't pinned, they'd look at it and have no idea; they'd have to go find out the last time the image got pushed. Actually this could be better in https://github.com/jbergknoff/dockerized-tools where images get tagged according to their versions. A PR adding youtube-dl there would be very welcome.
Aside: can you explain why WORKDIR /src is useful or necessary?
|
Thanks. The problem is: Often when a Website changes, youtube-dl doesn't work anymore. Because of this, even a slightly outdated youtube-dl-Version can cause youtube-dl to not work correctly. As long as the image is rebuilt regularly, it works if the version isn't pinned. (The best option would be for sure to make it fetch the version automatically on build and tag it accordingly - or even to trigger a rebuild on a new version) The WORKDIR spares me specifying the output-path manually (if I mount the destination in /src as shown in the Doku). According to dockerized-tools: How will there be taken care to build it using the current version number? Manually? The image will outdate extremly quickly so I am not sure if it makes even sense to add it ... |
No description provided.