Skip to content

fix: UB when calling empty YAML::Binary::data() #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SGSSGene merged 1 commit into from
Aug 14, 2026
+7 −1
Merged

fix: UB when calling empty YAML::Binary::data() #1482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/yaml-cpp/binary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class YAML_CPP_API Binary {
bool owned() const { return !m_unownedData; }
std::size_t size() const { return owned() ? m_data.size() : m_unownedSize; }
const unsigned char *data() const {
return owned() ? &m_data[0] : m_unownedData;
return owned() ? m_data.data() : m_unownedData;
}

void swap(std::vector<unsigned char> &rhs) {
Expand Down
6 changes: 6 additions & 0 deletions test/binary_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,9 @@ TEST(BinaryTest, DecodingTooShort) {
const std::vector<unsigned char> &result = YAML::DecodeBase64(input);
EXPECT_TRUE(result.empty());
}

TEST(BinaryTest, EmptyBinary) {
YAML::Binary b;
EXPECT_TRUE(b.size() == 0);
EXPECT_TRUE(b.data() == b.data()); // caused UB in the past
}