fix(snapshot): contain tar entry paths within destination directory - #472
Open
bunlongheng wants to merge 1 commit into
Open
fix(snapshot): contain tar entry paths within destination directory#472bunlongheng wants to merge 1 commit into
bunlongheng wants to merge 1 commit into
Conversation
jaypipes
approved these changes
Aug 10, 2026
jaypipes
left a comment
jaypipes
left a comment
Owner
There was a problem hiding this comment.
Thank you @bunlongheng for the clean PR summary and fix. Much appreciated :)
Owner
|
@bunlongheng please do sign the DCO. See here for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Untar helper in pkg/snapshot/unpack.go joins tar entry names to the destination root without checking whether the result stays inside it. A crafted snapshot archive with entries like ../../etc/cron.d/evil can write files outside the intended directory.
Added a filepath.Clean prefix check that rejects any entry - including symlinks whose target resolves outside root - before any file or directory is created.