-
Notifications
You must be signed in to change notification settings - Fork 7
fix(#298): add go install instructions to bundled notion-cli plugin #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
javimosch
wants to merge
1
commit into
master
Choose a base branch
from
am/am-f17c27-dkfgj4w7jxmc-e50a95d1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: javimosch/supercli
Length of output: 32633
🌐 Web query:
Go installation PATH GOPATH/bin default GOBIN documentation💡 Result:
When you run the go install command, Go compiles and installs executables into a specific directory controlled by the GOBIN and GOPATH environment variables [1][2]. The installation location is determined as follows: 1. If the GOBIN environment variable is set, binaries are installed into the directory specified by GOBIN [3][4]. GOBIN must be an absolute path [4]. 2. If GOBIN is not set, binaries are installed into the bin subdirectory of the first directory listed in the GOPATH environment variable [3][5]. 3. If neither GOBIN nor GOPATH is set, Go defaults to using $HOME/go/bin on Unix systems or %USERPROFILE%\go\bin on Windows [1][6][4]. To make these installed binaries easily executable from your command line, it is standard practice to add the binary installation directory (e.g., $HOME/go/bin) to your system PATH environment variable [3][7]. You can check your current configuration by running the command go env [3]. If you wish to change the default binary installation location, you can update GOBIN using: go env -w GOBIN=/your/custom/path/bin [3][7] Or, you can adjust the GOPATH workspace location to change where the default bin directory is located [6]. Note that while modern Go development primarily uses Go modules for dependency management, the GOPATH variable remains relevant for determining these default installation and cache locations [2][8][4].
Citations:
Make Go installation output reachable by SuperCLI.
go installwrites the binary toGOBIN, or$HOME/go/binwhenGOBINis unset. Add the installation directory toPATHbefore verification andinstall_steps, and document it in version/passthrough help and quickstart installation. If users omit this step,verify: which notion,notion --version, andnotionpassthrough calls can fail after installation succeeds.📍 Affects 3 files
plugins/notion-cli/install-guidance.json#L6-L7(this comment)plugins/notion-cli/plugin.json#L14-L14plugins/notion-cli/plugin.json#L33-L33plugins/notion-cli/plugin.json#L233-L233plugins/notion-cli/skills/quickstart/SKILL.md#L61-L63🤖 Prompt for AI Agents