Skip to content

feat: unify BashBot director command center#294

Merged
jasonsuhari merged 3 commits into
mainfrom
feat/unified-director-command-center
Jul 20, 2026
Merged

feat: unify BashBot director command center#294
jasonsuhari merged 3 commits into
mainfrom
feat/unified-director-command-center

Conversation

@jasonsuhari

Copy link
Copy Markdown
Owner

Summary\n\n- unify BashBot chat, the host shell, and continuous grid goals in the Alt+C command center\n- keep transcripts, shell state, goals, and asynchronous results scoped to their originating grid\n- report changed pane statuses and validated delivery receipts while excluding background or moved panes\n- remove the Alt+D, Alt+G, and Alt+U defaults with migration errors for their former key action names\n\n## Validation\n\n- cargo fmt --all -- --check\n- git diff --check\n- leased Cargo validation will run before merge\n\nRefs #284

@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🛡️ GridBash Review Agent

[P1] Removed key actions may break existing user configs

README.md, docs/REFERENCE.md, src/app.rs (keybindings)
The Alt+D, Alt+G, and Alt+U key actions are removed and replaced by Alt+C, but the migration path only reports an error if the [keys] table contains those names. Users with custom keybindings for these actions will encounter migration errors and lose those shortcuts, potentially breaking their workflow. To minimize disruption, provide a clear error message with actionable instructions, and consider mapping old actions to the new Alt+C command center when possible.

[P1] Per-grid state is not persisted in session files

src/app.rs (GridTabSnapshot, transcript, manager_goal, assistant, command_line)
The new per-grid transcript, shell state, and goal are intentionally not written to session files. This means that on restart, users lose all command center history and active goals, which may lead to confusion or data loss if they expect session recovery to include these states. Add explicit UI messaging or documentation warnings about this limitation, and consider offering an opt-in persistence mechanism for critical state.

[P2] Voice input destination logic may be ambiguous

src/app.rs (VoiceDestination enum, Alt+Shift+V behavior)
Voice input now routes to the active Director Chat or Shell input, or to the panes targeted when listening began. However, the logic for determining the correct destination may be ambiguous if the command center is not open or if multiple grids are active. Add regression tests and clarify the routing logic to ensure voice input always goes to the intended target.

[P2] Fuzzy matching test changed but may miss removed actions

src/actions.rs (fuzzy_matching_accepts_labels_ids_and_keywords)
The test for fuzzy matching now checks "orchestrate" against Action::CommandLine instead of Action::EditGoal, but the removal of EditGoal and StopGoal may leave gaps in search discoverability for users accustomed to those terms. Ensure that all relevant keywords for removed actions are included in the new CommandLine action's search keywords, and add tests for legacy queries.

Verdict

Merge is reasonable with clear migration messaging and documentation updates, but address user-facing breakage and clarify voice input routing before release. Validation gaps remain in session persistence and cross-grid state recovery.

Review input limitations
Truncated patches: ["src/app.rs"]
Omitted files: ["src/keybindings.rs","src/manager.rs","src/ui.rs"]

Model: openai/gpt-4.1 · Commit: ef9a1397383b · Scope: 5/8 files represented; input was truncated. AI feedback can be wrong; verify findings before changing code.

Consolidate per-grid chat, shell, and continuous goal orchestration behind Alt+C.\n\nRefs #284

Signed-off-by: Jason Matthew Suhari <jasonmatthewsuhari@gmail.com>
Signed-off-by: Jason Matthew Suhari <jasonmatthewsuhari@gmail.com>
Signed-off-by: Jason Matthew Suhari <jasonmatthewsuhari@gmail.com>
@jasonsuhari
jasonsuhari force-pushed the feat/unified-director-command-center branch from 45ac8ca to ef9a139 Compare July 20, 2026 19:25
@jasonsuhari
jasonsuhari merged commit 646adfb into main Jul 20, 2026
8 checks passed
@jasonsuhari
jasonsuhari deleted the feat/unified-director-command-center branch July 20, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant