Repository navigation
fix: security - upgrade sharp to 0.35.5 (libheif RCE) - #257
Merged
Merged
Conversation
miniflare@5.20260826.0-alpha depends on sharp@0.35.2 exactly. Override that edge to sharp 0.35.5 and its libvips 1.3.4 binaries so the lockfile no longer resolves the libheif RCE. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 1868 1868
Branches 412 412
=========================================
Hits 1868 1868 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
No application code changed. The existing suite still passes with 100% line coverage.
What kind of change does this PR introduce?
Security fix.
miniflare@5.20260826.0-alpha(pulled in bywrangler@4.127.0) pinssharpexactly at0.35.2. A scoped pnpm override,miniflare>sharp→0.35.5, is the only way to move that copy. No other dependencies were upgraded.sharp@0.35.5and the matching@img/*binaries were published on 2026-09-27, outside the 7-dayminimumReleaseAgewindow, so the cooldown was left unchanged.Packages
sharp@img/sharp-darwin-arm64,@img/sharp-darwin-x64,@img/sharp-freebsd-wasm32,@img/sharp-linux-arm,@img/sharp-linux-arm64,@img/sharp-linux-ppc64,@img/sharp-linux-riscv64,@img/sharp-linux-s390x,@img/sharp-linux-x64,@img/sharp-linuxmusl-arm64,@img/sharp-linuxmusl-x64,@img/sharp-wasm32,@img/sharp-webcontainers-wasm32,@img/sharp-win32-arm64,@img/sharp-win32-ia32,@img/sharp-win32-x64@img/sharp-libvips-darwin-arm64,@img/sharp-libvips-darwin-x64,@img/sharp-libvips-linux-arm,@img/sharp-libvips-linux-arm64,@img/sharp-libvips-linux-ppc64,@img/sharp-libvips-linux-riscv64,@img/sharp-libvips-linux-s390x,@img/sharp-libvips-linux-x64,@img/sharp-libvips-linuxmusl-arm64,@img/sharp-libvips-linuxmusl-x64A production deploy/release is needed after merge for the fix to go live on mockhttp.org. The Docker image copies
node_modules, and the Cloudflare Worker is published from this repo, so the patched sharp is not on the live service until that deploy/release.