Repository navigation
Declare empty Worker vars in Wrangler - #252
Merged
Merged
Conversation
The dashboard asks for an empty vars object so deploys stay in sync. MONGODB_URI stays a secret. Its value is not in the file. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 1720 1720
Branches 386 382 -4
=========================================
Hits 1720 1720 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Config. Add the empty
varsobject that the Cloudflare dashboard shows for Production.Why
The dashboard says: update the Wrangler configuration so deploys stay in sync. The snippet is
"vars": {}.MONGODB_URIstays a dashboard secret. This change does not put the URI, the username, the password, or the host in the file.Verification
wrangler deploy --dry-runexits 0. The listed bindings areRATE_LIMITERandASSETS. No plain var is uploaded.Test audit
No test was added or deleted. The change is
wrangler.jsonconly.Do not merge, release, or deploy this PR.