Repository navigation
Use example.invalid for worker test URI fixtures - #251
Merged
Merged
Conversation
The health-check test used a mongodb.net host with a password-shaped token. Secret scanning flagged that fixture. The host is now example.invalid. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 1723 1723
Branches 385 389 +4
=========================================
Hits 1723 1723 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test fix. Remove a secret-scanning match from a worker test fixture.
Why
GitHub secret scanning flagged one URI in
test/worker.test.ts. The string is a fixture from the health-check tests. It is not a live Atlas credential. The host wasmongodb.netand the password token was long enough for the MongoDB pattern. Validity on the alert is Unknown.The two fixtures in that test now use
example.invalid. The test still checks that logs omit the password tokens and the full URI.Verification
pnpm test: 561 tests passed. Line coverage 100% (1438/1438).Test audit
No test was deleted. The same test still protects the request-URI swap and the redaction contract. Only the fixture host changed.
Do not merge, release, or deploy this PR. After it is on
main, close the secret alert as revoked. No Atlas password rotation is required for this fixture.