mono - test: Drop the blanket test retries from the storage packages - #2184
Merged
Merged
Conversation
Nine storage packages retried every failed test twice. That hid real problems: the valkey cluster tests were losing keys to @keyv/redis's FLUSHDB (#2180) and several tests raced a 100 ms TTL (#2182), and both only surfaced when a test failed three times in a row. With those fixed, a test that needs a retry to pass should fail CI so it gets fixed. Remove `retry: 2` from the vitest configs of cloudflare-kv, dynamo, etcd, memcache, mongo, mysql, postgres, redis and valkey. The Cloudflare KV live config keeps its retries: it calls the real Cloudflare API over the internet. AGENTS.md now says not to add retries to get CI green. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X5LJCvt3pkR7FtfyAdzg5x
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 56
Lines 5790 5790
Branches 997 988 -9
=========================================
Hits 5790 5790 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test infrastructure change.
Problem
Nine storage packages set
retry: 2in their Vitest config, so CI only failed when a test failed three times in a row. That hid real problems for a long time:@keyv/redis'sFLUSHDB, fixed in valkey - test: Run cluster tests on their own Valkey cluster #2180. In one CI run that race hit four tests, and retries hid three of them.With the known flaky tests fixed, a test that needs a retry to pass should fail CI so its cause gets fixed.
Changes
retry: 2and its comment from cloudflare-kv, dynamo, etcd, memcache, mongo, mysql, postgres, redis and valkey.vitest.live.config.ts): keeps its retries. It calls the real Cloudflare API over the internet, so a retry there covers a network blip, not our code.AGENTS.md: don't addretryto a config or a test to get CI green; fix the flaky test instead.Verification
retry. Biome skipsvitest.config.ts, so it doesn't lint these files.testsworkflow on this commit (this PR's run plus two dispatched), each on Node 22, 24 and 26: nine full test jobs, all passing.testsjobs, from 2026-09-29 to 10-03, for tests that only passed on a retry.🤖 Generated with Claude Code
https://claude.ai/code/session_01X5LJCvt3pkR7FtfyAdzg5x