Skip to content

mono - test: Drop the blanket test retries from the storage packages - #2184

Merged
jaredwray merged 1 commit into
mainfrom
claude/wizardly-lamport-lyi7hy
Oct 3, 2026
Merged

jaredwray merged 1 commit into
mainfrom
claude/wizardly-lamport-lyi7hy

Conversation

@jaredwray

@jaredwray jaredwray commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage. Test configuration only; adapter source and coverage are unchanged.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test infrastructure change.

Problem

Nine storage packages set retry: 2 in their Vitest config, so CI only failed when a test failed three times in a row. That hid real problems for a long time:

With the known flaky tests fixed, a test that needs a retry to pass should fail CI so its cause gets fixed.

Changes

  • Vitest configs: remove retry: 2 and its comment from cloudflare-kv, dynamo, etcd, memcache, mongo, mysql, postgres, redis and valkey.
  • Cloudflare KV live config (vitest.live.config.ts): keeps its retries. It calls the real Cloudflare API over the internet, so a retry there covers a network blip, not our code.
  • AGENTS.md: don't add retry to a config or a test to get CI green; fix the flaky test instead.

Verification

  • Configs: all nine load and no longer set retry. Biome skips vitest.config.ts, so it doesn't lint these files.
  • CI with no retries: green on every run.
    • Three runs of the tests workflow on this commit (this PR's run plus two dispatched), each on Node 22, 24 and 26: nine full test jobs, all passing.
    • The coverage, bun, browser and Cloudflare KV live checks also pass.
  • CI history: I scanned the last 45 tests jobs, from 2026-09-29 to 10-03, for tests that only passed on a retry.
    • Every hit was in one of the two groups already fixed: the Valkey cluster tests and the Postgres expires-column test.
    • The 12 jobs since those fixes had no retries.
    • Caveat: in CI, Vitest only prints the retry marker for slow tests or tests in a failing file, so quick tests that passed on retry don't show in the logs. That's another reason to stop retrying: from now on they'll fail visibly.

🤖 Generated with Claude Code

https://claude.ai/code/session_01X5LJCvt3pkR7FtfyAdzg5x

Nine storage packages retried every failed test twice. That hid real
problems: the valkey cluster tests were losing keys to @keyv/redis's
FLUSHDB (#2180) and several tests raced a 100 ms TTL (#2182), and both
only surfaced when a test failed three times in a row. With those fixed,
a test that needs a retry to pass should fail CI so it gets fixed.

Remove `retry: 2` from the vitest configs of cloudflare-kv, dynamo,
etcd, memcache, mongo, mysql, postgres, redis and valkey. The Cloudflare
KV live config keeps its retries: it calls the real Cloudflare API over
the internet.

AGENTS.md now says not to add retries to get CI green.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X5LJCvt3pkR7FtfyAdzg5x
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T18:17:29.776556Z 7db8c98 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (17a6f6a) to head (7db8c98).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         5790      5790           
  Branches       997       988    -9     
=========================================
  Hits          5790      5790           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray
jaredwray merged commit 6361ae1 into main Oct 3, 2026
23 checks passed
@jaredwray
jaredwray deleted the claude/wizardly-lamport-lyi7hy branch October 3, 2026 18:59
@jaredwray jaredwray mentioned this pull request Oct 4, 2026
8 of 10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants