Repository navigation
Handle uppercase cbr state in perf output - #378
Closed
yinli-systems wants to merge 2 commits into
Closed
yinli-systems wants to merge 2 commits into
yinli-systems wants to merge 2 commits into
Conversation
Signed-off-by: Kevin-Li-2025 <2242139@qq.com>
Signed-off-by: Kevin-Li-2025 <kxl474@student.bham.ac.uk>
Author
|
@Svetlitski, could you take a look when convenient? This is intentionally narrow: the ignored CBR state field now accepts uppercase letters, and the expect test uses the exact Ubuntu 24.04 / perf 6.8 line from #324 and asserts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #324.
Summary
cbrperf output before the secondcbr:payloadRoot cause
perf_cbr_event_reonly allowed lowercase letters in the optional text between the event name and frequency payload. Perf can emit uppercase task-state text such asD, so parsing raised before extracting the frequency.The regression verifies that the reported line parses as a
Powerevent with frequency3629MHz.Validation
Validated in a clean x86_64 Alpine 3.23.5 environment using the repository-pinned OxCaml switch and locked dependencies:
opam install . --deps-only --locked --with-testdune build @fmtmake PROFILE=staticdune runtest --profile=staticgit diff --checkAll commands completed successfully.
AI assistance
AI assistance was used to reproduce the repository's x86 build environment and inspect the validation output. I reviewed the code change, the issue fixture, and the resulting test evidence before submission.