Skip to content

Export SVG files to work with PDFs - #108

Open
rmccrear wants to merge 4 commits into
jakartaee:mainfrom
rmccrear:fix-svg-pdf
Open

Export SVG files to work with PDFs#108
rmccrear wants to merge 4 commits into
jakartaee:mainfrom
rmccrear:fix-svg-pdf

Conversation

@rmccrear

@rmccrear rmccrear commented Mar 28, 2024

Copy link
Copy Markdown

This PR...

The SVG files were saved as "editable SVG". This works fine for browsers, but doesn't work in a PDF. I just re-exported them and now they look fine in the PDF.

TODO:

  • Update the SVG files in /src/.../modules/security/images

@kito99

kito99 commented Apr 30, 2024

Copy link
Copy Markdown

thanks @rmccrear! Looks like this one slipped through the cracks. Can you update the ones in the security/images folder and also address the ECA issue? https://api.eclipse.org/git/eca/status/gh/jakartaee/jakartaee-tutorial/108

@kito99

kito99 commented May 30, 2024

Copy link
Copy Markdown

@rmccrear please see prior comment

@kito99

kito99 commented Sep 6, 2024

Copy link
Copy Markdown

@rmccrear bump

@kito99

kito99 commented Oct 26, 2025

Copy link
Copy Markdown

@rmccrear pinging you once again

@rmccrear

Copy link
Copy Markdown
Author

I’ve tried to sign the eca, but it doesn’t like me.

@kito99

kito99 commented Oct 27, 2025

Copy link
Copy Markdown

I’ve tried to sign the eca, but it doesn’t like me.

Can you be more specific @rmccrear ?

@rmccrear
rmccrear marked this pull request as ready for review November 3, 2025 22:25
@rmccrear

Copy link
Copy Markdown
Author

Looks like I've got the ECA to validate.

@kito99

kito99 commented Apr 4, 2026

Copy link
Copy Markdown

@rmccrear thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants