Skip to content

Show Readflow on demand and automate the macOS bridge - #12

Closed
jaibhasin wants to merge 10 commits into
mainfrom
codex/on-demand-readflow
Closed

jaibhasin wants to merge 10 commits into
mainfrom
codex/on-demand-readflow

Conversation

@jaibhasin

@jaibhasin jaibhasin commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Readflow currently adds a player automatically on article pages and requires a manually running bridge.
This change makes the toolbar icon summon the compact Walkman only when requested, with playback starting after pressing Play.

  • Replace the reading-list toolbar popup and automatic content scripts with activation through activeTab and scripting.
  • Reuse an existing player on repeat clicks, support selected passages on ordinary pages, and show toolbar feedback for protected pages.
  • Add a reversible macOS login service with automatic bridge restart, health/status checks, loopback binding, and existing .env key handling.
  • Update usage and service installation instructions; preserve the small feature commits and integrate the latest saved-speed changes from main.
  • Fix the browser recovery assertion to compare the exact saved disconnect position instead of the earlier clicked word, and isolate fixture servers on OS-assigned ports.

Validation: type checking, production build, all 117 JavaScript tests, and all 3 Python tests passed.
The login service was installed and its running bridge passed the health check on macOS.
The built-player tests cover compact startup, no autoplay, activation acknowledgement, and duplicate prevention.
The full real-browser regression passed locally, including the 45-second paused interval and recovery after playback advances.
The old assertion was reproduced failing even though the recovery request matched the saved position, before applying the fix.
Live Chrome toolbar interaction and Fish Audio provider playback remain unverified; browser playback uses a controlled extension port and local mock audio.

After merging and pulling: run npm run build, reload Readflow at chrome://extensions, and refresh existing article tabs once.
On the configured Mac, the bridge service is already installed; other Macs need the documented one-time service installation.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9b831c7e-ffdb-40ba-9b48-cb17c61f7f88
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jaibhasin

Copy link
Copy Markdown
Owner Author

Superseded by #13, which includes all changes from this PR plus the on-demand native Mac app and macOS build checks. Please review and merge #13 instead.

@jaibhasin jaibhasin closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant