Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readflow currently adds a player automatically on article pages and requires a manually running bridge.
This change makes the toolbar icon summon the compact Walkman only when requested, with playback starting after pressing Play.
activeTabandscripting..envkey handling.Validation: type checking, production build, all 117 JavaScript tests, and all 3 Python tests passed.
The login service was installed and its running bridge passed the health check on macOS.
The built-player tests cover compact startup, no autoplay, activation acknowledgement, and duplicate prevention.
The full real-browser regression passed locally, including the 45-second paused interval and recovery after playback advances.
The old assertion was reproduced failing even though the recovery request matched the saved position, before applying the fix.
Live Chrome toolbar interaction and Fish Audio provider playback remain unverified; browser playback uses a controlled extension port and local mock audio.
After merging and pulling: run
npm run build, reload Readflow atchrome://extensions, and refresh existing article tabs once.On the configured Mac, the bridge service is already installed; other Macs need the documented one-time service installation.