Skip to content

overhaul the LESStep demo and rename it to BackwardFacingStep#312

Open
muezabdalla wants to merge 5 commits into
jaheyns:devfrom
muezabdalla:backwardFacingStep2
Open

overhaul the LESStep demo and rename it to BackwardFacingStep#312
muezabdalla wants to merge 5 commits into
jaheyns:devfrom
muezabdalla:backwardFacingStep2

Conversation

@muezabdalla

Copy link
Copy Markdown
Contributor

I kept all the parameters the same except the startFrom (I changed it from latestTime to startTime)

App.ActiveDocument.PhysicsModel.Time = 'Transient'
App.ActiveDocument.PhysicsModel.Turbulence = 'LES'
App.ActiveDocument.PhysicsModel.TurbulenceModel = 'kEqn'
App.ActiveDocument.InitialiseFields.PotentialFlow = False

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialisation of p and U do not seem to be set up?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will still need to set
App.ActiveDocument.InitialiseFields.UseOutletPValue = True
like in the original macro

dimensions [0 2 -2 0 0 0 0];

internalField uniform 0.0;
internalField uniform 83333.33333333334;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Do the tests pass though? This seems like a strange p value...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry for that I did not run the test because I thought this will not affect it and I was in a a hurry. but now I fixed it with the other typos and errors.

App.ActiveDocument.InitialiseFields.Ux = '0.0 mm/s'
App.ActiveDocument.InitialiseFields.Uy = '0.0 mm/s'
App.ActiveDocument.InitialiseFields.Uz = '0.0 mm/s'
APP.ActiveDocument.InitialiseFields.BoundaryP = FreeCAD.ActiveDocument.CfdFluidBoundary001

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in 'APP'? Have you tested this?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CfdFluidBoundary001 doesn't yet exist - only created in part 04 - so I think the setting of the initialisation should be moved to after the BCs.

App.ActiveDocument.PhysicsModel.Time = 'Transient'
App.ActiveDocument.PhysicsModel.Turbulence = 'LES'
App.ActiveDocument.PhysicsModel.TurbulenceModel = 'kEqn'
App.ActiveDocument.InitialiseFields.PotentialFlow = False

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will still need to set
App.ActiveDocument.InitialiseFields.UseOutletPValue = True
like in the original macro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants