add Time settings ui#309
Open
muezabdalla wants to merge 4 commits into
Open
Conversation
oliveroxtoby
requested changes
Jul 15, 2026
|
|
||
| # Constants | ||
| START_FROM = ["startTime", "latestTime"] | ||
| START_FROM_NAMES = ["start time", "latest time"] |
Collaborator
There was a problem hiding this comment.
Please use initial capitalisation consistent with the rest of the UI (Start time, Latest time).
| self.working_dir = CfdTools.getOutputPath(self.analysis_object) | ||
|
|
||
| self.form.comboBoxStartFrom.setToolTip("Whether to start from 0 or from the latest time step") | ||
| self.form.inputFieldEndTime.setToolTip("the end time for the simulation") |
Collaborator
There was a problem hiding this comment.
Please use initial capitalisation (here and below)
| </font> | ||
| </property> | ||
| <property name="text"> | ||
| <string>time Parameters</string> |
Collaborator
There was a problem hiding this comment.
Please use initial capitalisation ("Time parameters") - also for other labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is for when the steady cases:
and this for transient cases:
