release: v3.11.2 — dream progress feedback (spinner + valid measures) - #75
Closed
jagoff wants to merge 4 commits into
Closed
release: v3.11.2 — dream progress feedback (spinner + valid measures)#75jagoff wants to merge 4 commits into
jagoff wants to merge 4 commits into
Conversation
Console(force_terminal=False) short-circuits Rich 15's is_terminal to False before isatty(), so memo emitted no ANSI and the dream pipeline's spinner/progress bar never rendered — the run looked frozen after the pre-dream inventory panel with zero feedback. Let the shared console auto-detect (Console()), and gate _make_progress on console.is_terminal (the stream it renders to) instead of sys.stderr.isatty().
The dream pipeline runs two tasks in one Progress: a determinate 'overall' task (the N/14 pipeline bar) and a rolling 'step' status line with total=None. The stock BarColumn + MofNCompleteColumn rendered a full/pulsing bar and a meaningless '0/?' for the indeterminate step (e.g. 'recall self-tuner... 0/?'). Blank both columns when task.total is None so the step shows just spinner + description + elapsed; the overall bar keeps its real N/14 measure.
Owner
Author
|
Closing as stale/superseded. This is a v3.11.2 release PR; master is now at v4.4.3 (released today). The dream progress-feedback work it carried is long superseded. Reopen if any specific commit here is still wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Patch release v3.11.2. Supersedes #74 — bundles both
memo dream runprogress fixes into one PR onto master.Contains, on top of #73:
6287ce53fix(dream): restore progress spinner in real terminals (v3.11.1)8b16fc70fix(dream): blank bar + counter for the indeterminate status line (v3.11.2)Why
memo dream rungave no usable progress feedback:Consoleusedforce_terminal=False, which Rich 15 short-circuits inis_terminalbefore theisatty()check → zero ANSI, the spinner/bar never rendered. The run looked frozen after the pre-dream inventory panel.stepstatus line (total=None) rendered a full/pulsing bar and a meaningless0/?counter (e.g.recall self-tuner... 0/?).Fixes
cli_common.py:Console()auto-detects the terminal (TTY → colour + spinner; pipes/tests/launchd → plain).dream_utils._make_progress: gatedisableonconsole.is_terminal; add_DeterminateBarColumn/_DeterminateMofNColumnthat blank out fortotal is None, so the status line is spinner + description + elapsed and only theoveralltask shows the real N/14 bar.tests/test_dream_progress_tty.py: 5 regression tests (TTY gating + indeterminate-column blanking).Test plan
ruff+mypyclean on changed files0/?; non-TTY stays plainTags
v3.11.1andv3.11.2already pushed; both become ancestors of master when this merges.