docs(deployment): Describe what the shipped Kafka ingester configs demonstrate - #1150
Merged
yurishkuro merged 1 commit intoSep 23, 2026
Merged
Conversation
…nd tidy three sentences Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#1149 merged before its last review-round commit reached the branch, so four prose corrections from that round are missing on
main.Description of the changes
config-kafka-ingester-sync.yamlandconfig-kafka-ingester-dead-letter.yaml"the complete ingester configuration". They say the files demonstrate the offset coupling but setqueue.batch.min_size: 0, omitblock_on_overflow, and (for the dead-letter one) end in anotlphttpsink, so a reader copying them knows what differs from the recommended shape.retry_on_failurebullet it justifies.How was this change tested?
npm run check:formatandcheck:spellingpass; the content is the commit reviewed on #1149.