Skip to content

docs(deployment): Describe what the shipped Kafka ingester configs demonstrate - #1150

Merged
yurishkuro merged 1 commit into
jaegertracing:mainfrom
ysh-bot:docs-ingester-config-caveats
Sep 23, 2026
Merged

yurishkuro merged 1 commit into
jaegertracing:mainfrom
ysh-bot:docs-ingester-config-caveats

Conversation

@ysh-bot

@ysh-bot ysh-bot commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Which problem is this PR solving?

#1149 merged before its last review-round commit reached the branch, so four prose corrections from that round are missing on main.

Description of the changes

  • The Delivery Guarantees and Kafka pages no longer call the shipped ingester files config-kafka-ingester-sync.yaml and config-kafka-ingester-dead-letter.yaml "the complete ingester configuration". They say the files demonstrate the offset coupling but set queue.batch.min_size: 0, omit block_on_overflow, and (for the dead-letter one) end in an otlphttp sink, so a reader copying them knows what differs from the recommended shape.
  • The sentence that the retry is safe because span writes are idempotent moves to the retry_on_failure bullet it justifies.
  • The translog durability sentence is made grammatical.
  • The connector's log line is described as one warning per distinct trace id and span id pair, as the code does.

How was this change tested?

npm run check:format and check:spelling pass; the content is the commit reviewed on #1149.

…nd tidy three sentences

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
yurishkuro merged commit 4017782 into jaegertracing:main Sep 23, 2026
9 checks passed
@yurishkuro
yurishkuro deleted the docs-ingester-config-caveats branch September 23, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants