fix: repaired release preflight checks - #204
Merged
Merged
Conversation
- Matched platform constraints for quota recovery tests. - Accepted current cask hooks and corrected version checks. - Restricted validation cleanup to owned state. - Removed forced publication pushes.
- Checked launchd availability before lifecycle validation. - Reported job state and plist validation after failed installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release preflight on current main failed Windows vet because quota recovery tests referenced a non-Windows harness. Homebrew lifecycle validation also rejected the published cask's
postflight_stepshook before installation.Validation
GOOS=windows GOARCH=amd64 go vet ./...now passes.